Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Cosmetic and Entitlement Updates #184

Merged
merged 25 commits into from
Feb 24, 2023

Conversation

Nerixyz
Copy link
Collaborator

@Nerixyz Nerixyz commented Jan 30, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

This implements the new cosmetics system.

@Nerixyz Nerixyz marked this pull request as ready for review February 16, 2023 10:09
@Nerixyz
Copy link
Collaborator Author

Nerixyz commented Feb 16, 2023

This shouldn't be merged yet, as a release of upstream Chatterino is around the corner. It should be tested here and merged after the release, to have nightly users test it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 42. Check the log or trigger a new build to see more.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link

@AnatoleAM AnatoleAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To discuss for upstream:

creating a mechanism to allow re-rendering of badges. Currently if the entitlement events come through after the message is painted, it will require the user to type twice to see their new badge.

@AnatoleAM AnatoleAM merged commit 2379061 into SevenTV:chatterino7 Feb 24, 2023
@Nerixyz Nerixyz deleted the feat/cosmetics branch February 24, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants