-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Personal Emotes #192
Conversation
e558b1f
to
3c711d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
sharing is caring
35daae1
to
d8135fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
This probably should be tied to the socket's lifecycle; i.e clear the data after a successful non-resumed connection. Otherwise, the EventAPI wouldn't send the data again. |
I don't think there's much need for this then, compared to the required bookkeeping. The images for the emotes are automatically deleted after a while. And I don't think the emote-sets take that much space (about 1KiB/Set - a 32x32 emote with 25 frames takes about 100KiB). Furthermore, there aren't many reconnects, so this data would even with the bookkeeping stay in memory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, i may have some nitpicks later but we can let this cook in nightly for a while and if needed have a subsequent PR
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
This PR implements personal emotes.
Known bugs/tasks:
Personal emotes are not yet deleted after they haven't been used in a while (the images for the emotes however are deleted as always).Subs
tab instead ofChannel
.