Animated Profile Avatar

[melon095]

Pull request checklist:

• CHANGELOG.md was updated, if applicable

Description

Added option in Misc to show SevenTV animated avatar rather than the default Twitch.
Avatars are cached. (This can be improved)

[anqueue]

Functionality works as intended, but a couple things:

• Loading the profile picture from a usercard takes longer now. Maybe load the twitch pfp first then 7tv animated pfp?
• Show 7TV Animated Profile Picture should be on by default

[melon095]

Hello, i have tried to modify the code to better fit your requirements. Please let me know if there is anything else you want me to change.

[TroyKomodo]

Hi @mmattbtw Can you do a rebase on this pr?

[mmattbtw]

Not my PR lol :^)
pinging @JoachimFlottorp

[TroyKomodo]

Whoops.

[melon095]

Hope that was the correct button. 👍

[TroyKomodo]

@MrAuro @mmattbtw can you please confirm these changes work.

[anqueue]

Works as intended for me on Windows 👍

[TroyKomodo]

Almost works,

bug.mp4

Notice how the transparent layers are not respected on the image.

[TroyKomodo]

@MrAuro can u confirm this is the case. check sodapoppins user card.

[melon095]

This seems to have been an error only on release which is why i did not see it. I seem to have fixed it and can verify that this fix works in the release build

2022-03-25.21-41-59.mp4

[anqueue]

@TroyKomodo Can you run actions on the latest commit, ill test once those finish

[TroyKomodo]

@JoachimFlottorp still seems off on mine, but could be because i am running it from WSL and into windows.

[TroyKomodo]

@JoachimFlottorp can you verify it works on linux?

[melon095]

I'll check it on a linux machine once it builds.

[anqueue]

Transparency works on latest build. (windows, qmake)

[melon095]

I have checked on linux using Virtualbox and a physical device, i have verified that the AppImage from github actions produces the same error. But building chatterino myself on linux does not show this error.

AppImage in virtualbox
https://user-images.githubusercontent.com/24413121/160210396-d52c6a64-3958-409f-9df8-6ae253b4ceaa.mp4

AppImage on physical linux
https://user-images.githubusercontent.com/24413121/160207598-d7c0ec58-eacc-48ba-82d2-140feaa635c4.mp4

Built using QTCreator in virtualbox
https://user-images.githubusercontent.com/24413121/160210455-447df0fe-c27c-4554-b93f-c8f16322d5b2.mp4

[TroyKomodo]

So is it a dependency issue then?

[melon095]

I might have tracked it down to a wayland issue. I downloaded the three dependencies libwayland-dev libwayland-egl1-mesa libwayland-server0, and ran a AppImage that i built locally. Yes it did remove the transparent flickering. I also tested it on a x11 machine, and found no flickering.

https://wiki.qt.io/QtWayland#Create_and_Run_your_own_Wayland_Compositor_with_Qt5

I will modify the Ubuntu CI to install the three dependencies just to verify this fixes that. If that is alright with you.

Someone would also need to verify on MacOS if there is any issue with this.

X11
https://user-images.githubusercontent.com/24413121/160217087-49d2397b-aa04-4dca-8326-d44bf4bfd2af.mp4

[TroyKomodo]

Thank you, yes please do update the CI in this pr.

[melon095]

Hi, been busy these lately days, But i was wrong about it being wayland, good job on my side Either way. If im correct it's only an issue on Qt 5.12.10. And Qt 5.15.2 Doesn't have it. No idea how you want to fix this, i would just remove 5.12.10 from being built. But not like i have control over upstream.

[TroyKomodo]

Ok, that's fine with me. Please make the changes to this pr on the qt version in cmake and ci. And I'll review them once they are in.

…

On Tue, 29 Mar 2022, 13:34 JoachimF, ***@***.***> wrote: Hi, been busy these lately days, But i was wrong about it being wayland, good job on my side [image: image] <https://user-images.githubusercontent.com/24413121/160670216-d4c5ad1f-71f0-401a-a439-150e82e3b479.png> Either way. If im correct it's only an issue on Qt 5.12.10. And Qt 5.15.2 Doesn't have it. No idea how you want to fix this, i would just remove 5.12.10 from being built. But not like i have control over upstream. — Reply to this email directly, view it on GitHub <#69 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL3YU5J55ZFYMULMMB6I42DVCM5KRANCNFSM5MSPDVYA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[TroyKomodo]

@JoachimFlottorp Can you also update the install guide for installing the correct version of qt, and any other changes required for any dep change, such as cmake or anywhere where the minimum version has now changed.

[melon095]

A few notes. VVVV

Problem at .docker/Dockerfile.build Seems like Offline Installations have been removed since Qt 5.15.

PPA Repositories travis Use has removed the meta package in version Qt 5.15 Here.
Another package which could replace is qtbase5-dev however, has different paths.

Build files such as .CI/CreateAppImage.sh requires also a fix, to fit newer paths.

[TroyKomodo]

@JoachimFlottorp can u actually remove the one line breaking formatting. I am aware I introduced the line change but remove it in this pr and ill merge it. i am happy.

[AnatoleAM]

This seems good at least for this fork, though I'll note there has been discussion before on adding further network requests on opening user cards, which may be an issue when submitting this to the upstream branch.

[TroyKomodo]

@JoachimFlottorp Any updates on this?

[Felanbird]

@JoachimFlottorp Any updates on this?

I'm perfectly happy to PR the line removal 🙂