fix: pass config prop to the renderer #96
Conversation
Yeah, sorry about that. I have fixed the formatting issue. |
|
Hi @ShaMan123 , could you please review the changes, merge the PR and push a release. This would help so many waiting for the fix. |
package.json
Outdated
There was a problem hiding this comment.
please undo this change, npm scripts handle semver changes
| const { config: configProps } = props as MathTextItemProps<true>; | ||
| const config = useMemo(() => ({ ...(configProps || {}), inline }), [inline, configProps]); |
There was a problem hiding this comment.
If config is always passed as optional then you should change MathTextItemProps it seems.
config?: MathViewProps['config']
There was a problem hiding this comment.
The MathTextItemProps extends from MathViewCommonProps which defines config as optional, which I guess is intentional? Because if you look at the MathTextItemProps it optionally extends from MathViewCommonProps if the generic type is a boolean. Not sure what the purpose is for this optional extension.
export type MathTextItemProps<T extends boolean = boolean> = (T extends true ? Omit<MathViewProps, 'math'> : TextProps) & {
value: string,
isMath: T,
Component?: MathView,
CellRendererComponent?: ElementOrRenderer,
inline?: boolean
}
There was a problem hiding this comment.
So I prefer to spread config: configProp in line 43 if that is possible.
Sorry for the delay and for not being acquainted with the code anymore.
Actually, I think it is best you fork and I archive this repo with a pinned issue stating so so other devs can write there what they want.
|
I suggest you fork |
closes #49