fix(Gamepad Settings): add mouse handling for gamepad settings button #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastaq
reviewed
Jan 26, 2025
|
|
||
| # If the user presses the gamepad settings button with a non-gamepad input method, | ||
| # open the settings for the first detected controller. | ||
| # TODO: Add a controller select pop-up to select a gamepad to configure |
There was a problem hiding this comment.
We should prioritize this soon, along with gamepad ordering. This shouldn't be exclusive to mouse/touch input though, I think it would be reasonable to configure multiple gamepads with player 1 for example .
pastaq
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for using mouse or keyboard input to open the gamepad settings.