feat: add suspend_mode attribute and associated logic #10
Conversation
ayaneo-platform.c
Outdated
| @@ -568,8 +699,14 @@ static int ayaneo_platform_probe(struct platform_device *pdev) | |||
| ret = PTR_ERR_OR_ZERO(match); | |||
| if (ret) | |||
| return ret; | |||
|
|
|||
| ret = devm_device_add_groups(dev, ayaneo_led_mc_groups); | |||
There was a problem hiding this comment.
dev here adds the attribute to the platform device. During the init we have access to the led_mc dev via struct led_classdev *led_cdev = &ayaneo_led_mc.led_cdev;. If we use this instead, the attribute will be accessible through sys/class/leds/multicolor:chassis with all the other attributes instead of /sys/class/leds/multicolor:chassis/device with the platform attributes. As this is specifically related to the suspend mode of the led_mc I think it makes more sense to have it attached to the led device.
There was a problem hiding this comment.
I've moved the attribute to the led device as suggested; definitely better that way.
|
This exposes some strange behavior on the air plus. I know you don't have a device to test it on so I won't hold up the PR for it, but I did find superfluous code while troubleshooting it. The write and the open at likes 390/393 are not necessary. The bug is that in "off" mode only the right LED turns back on, and in "keep" mode the right LED turns off when resuming. If you have any insight here that would be appreciated. |
Implements switchable suspend logic for LEDs.
Behavior can be set with
/sys/class/leds/multicolor:chassis/device/suspend_mode.Supported behaviors:
Tested on AyaNeo Air Pro. Other devices should work, but not confirmed.