Generate .deb package from build #15
Conversation
finrodfelagund97
requested review from
dwigton,
buttercat1791 and
SilberWitch
finrodfelagund97
assigned finrodfelagund97 and buttercat1791 and unassigned finrodfelagund97
| @@ -73,38 +75,58 @@ target_link_libraries(aedile PRIVATE | |||
| plog::plog | |||
| websocketpp::websocketpp | |||
| ) | |||
| target_include_directories(aedile PUBLIC ${INCLUDE_DIR}) | |||
| target_include_directories(aedile PUBLIC $<BUILD_INTERFACE:${INCLUDE_DIR}/>) | |||
There was a problem hiding this comment.
Can you explain what the BUILD_INTERFACE part means here?
| mkdir -p ${DEB_PACKAGE_ROOT}/usr/include/aedile/client | ||
| mkdir -p ${DEB_PACKAGE_ROOT}/usr/lib | ||
|
|
||
| ln -s ${INSTALL_DIR}/include/nostr.h ${DEB_PACKAGE_ROOT}/usr/include/aedile/nostr.h |
There was a problem hiding this comment.
Why are we adding this nostr.h file?
There was a problem hiding this comment.
It looks like we ditched it between master and note_signing. It probably shouldn't exist as it just does some C++ header imports.
#include <nostr.hpp>
#include <client/web_socket_client.hpp>
Edit: I'm retarded, it was added below. I'll wait for explanation :)
There was a problem hiding this comment.
I do need to get note_signing up to speed and merge it into master, it's been divergent from master for too long at this point.
My guess is that nostr.h is acting as a whole-library "entrypoint" header file.
There was a problem hiding this comment.
It made me realize we need to prune up some of our public api headers too. I don't think they need to be including all the headers listed at the moment.
There was a problem hiding this comment.
I think we will eventually have just a nostr.hpp that, in turn, imports everything from the project internals. But we're not there yet.
| #! /bin/bash | ||
|
|
||
| export PACKAGE_NAME="libaedile-dev" | ||
| export VERSION="0.0.2" |
There was a problem hiding this comment.
Should we be centralizing the build version somehow so we don't need to remember to increment versions at every location? Or will this be the entry-point for the entire package? I assume some users will be building from cmake directly.
There was a problem hiding this comment.
For now, this is a util script.
Ideally, the build will be done on a jenkins job, and there we can set these variables as env variables for the job.
There was a problem hiding this comment.
Seems to be in dos format, needed to convert to unix line endings before running on Debian.
There was a problem hiding this comment.
Are you sure?
I'm pretty sure it's unix line endings
There was a problem hiding this comment.
Looks like your probably right. Pulled a clean version and ran dos2unix then git diff and no changes were detected this time. It looks like git might have changed it to crlf and staged it without me noticing, which is why when I converted it last time it showed up in the diff. Not sure.
Now we're able to generate a .deb package after building aedile-ndk.
This .deb package can be installed like other .deb package:
sudo dpkg -i /path/to/deb/package.debI've also disable naive test build.
Now during the cmake configure step, to build the tests, the variable 'ENABLE_TESTS' must be set to 1
I've shown how to do that in the README.