Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Code Documentation for Banking App #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve Code Documentation for Banking App #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
153 changes: 85 additions & 68 deletions Banking App/banking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,27 @@

import random
import sys
import sqlite3
random.seed()

# Set the random seed for reproducibility
random.seed()

# Connect to SQLite database
conn = sqlite3.connect('card.s3db')
cur = conn.cursor()
# cur.execute("DROP TABLE card")

# Create the 'card' table if it doesn't exist
cur.execute("CREATE TABLE IF NOT EXISTS card(id INTEGER PRIMARY KEY,number TEXT,pin TEXT,balance INTEGER DEFAULT 0);")
conn.commit()


class Card:
"""
A class representing a card in a banking system.

This class handles account creation, login, and various banking operations.
"""

def __init__(self):
"""Initialize Card object with default values."""
self.card = ''
self.pin = ''
self.login_card = ''
Expand All @@ -24,6 +31,7 @@ def __init__(self):
self.receiver_balance = 0

def create_account(self):
"""Create a new account with a unique card number and PIN."""
print("Your card has been created")
print("Your card number:")
self.card = '400000' + str(random.randint(100000000, 999999999))
Expand All @@ -35,10 +43,11 @@ def create_account(self):
conn.commit()

def log_in(self):

"""Handle user login process."""
self.login_card = input("Enter your card number:\n")
self.login_pin = input("Enter your PIN:\n")

# Verify login credentials
cur.execute(f"""SELECT
id,
number,
Expand All @@ -56,14 +65,11 @@ def log_in(self):
self.balance = self.row[3]
print('\nYou have successfully logged in')
self.success()

else:
print("wrong card number or pin")

'''elif not self.luhn_2(self.login_card):
print('Probably you made a mistake in the card number. Please try again!')'''

def success(self):
"""Handle successful login and provide menu options."""
while True:
print("""\n1. Balance
2. Add income
Expand All @@ -76,39 +82,11 @@ def success(self):
print('\nBalance: ', self.balance)
print()
elif i == 2:
print('\nEnter income:')
amount = int(input())
self.balance += amount
cur.execute(f'UPDATE card SET balance = {self.balance} WHERE number = {self.login_card};')
conn.commit()
print('Income was added!')
self.add_income()
elif i == 3:
print('\nTransfer\nEnter card number:')
receiver_card = input()
cur.execute(f'SELECT id, number,pin,balance FROM card WHERE number = {receiver_card};')

if not self.luhn_2(receiver_card):
print('Probably you made a mistake in the card number. Please try again!')
elif not cur.fetchone():
print('Such a card does not exist.')
else:
transfer = int(input("Enter how much money you want to transfer:\n"))
if transfer > self.balance:
print("Not enough money!")
else:
self.balance -= transfer
cur.execute(f'UPDATE card SET balance = {self.balance} WHERE number = {self.login_card};')
self.receiver_balance += transfer
cur.execute(f'UPDATE card SET balance = {self.receiver_balance} WHERE number = {receiver_card};')
cur.execute(f'SELECT * FROM card WHERE number = {self.login_card}')
print(cur.fetchone())
print("Success!")
conn.commit()

self.do_transfer()
elif i == 4:
cur.execute(f"DELETE FROM card WHERE number = {self.login_card}")
conn.commit()
print('\nThe account has been closed!')
self.close_account()
break
elif i == 5:
print("\nYou have successfully log out!")
Expand All @@ -118,53 +96,91 @@ def success(self):
conn.close()
sys.exit()

def add_income(self):
"""Add income to the account."""
print('\nEnter income:')
amount = int(input())
self.balance += amount
cur.execute(f'UPDATE card SET balance = {self.balance} WHERE number = {self.login_card};')
conn.commit()
print('Income was added!')

def do_transfer(self):
"""Handle money transfer between accounts."""
print('\nTransfer\nEnter card number:')
receiver_card = input()
cur.execute(f'SELECT id, number,pin,balance FROM card WHERE number = {receiver_card};')

if not self.luhn_2(receiver_card):
print('Probably you made a mistake in the card number. Please try again!')
elif not cur.fetchone():
print('Such a card does not exist.')
else:
transfer = int(input("Enter how much money you want to transfer:\n"))
if transfer > self.balance:
print("Not enough money!")
else:
self.balance -= transfer
cur.execute(f'UPDATE card SET balance = {self.balance} WHERE number = {self.login_card};')
self.receiver_balance += transfer
cur.execute(f'UPDATE card SET balance = {self.receiver_balance} WHERE number = {receiver_card};')
cur.execute(f'SELECT * FROM card WHERE number = {self.login_card}')
print(cur.fetchone())
print("Success!")
conn.commit()

def close_account(self):
"""Close the current account."""
cur.execute(f"DELETE FROM card WHERE number = {self.login_card}")
conn.commit()
print('\nThe account has been closed!')

def luhn_2(self, num):
num2 = num[:]
num2 = num2[::-1]
"""
Validate card number using Luhn algorithm.

Args:
num (str): Card number to validate.

Returns:
bool: True if card number is valid, False otherwise.
"""
num2 = num[::-1]
lst = [int(x) for x in num2]
s1 = sum(lst[::2])
for i in range(len(lst)):
if i % 2 != 0:
lst[i] = lst[i] * 2
for i in range(len(lst)):
for i in range(1, len(lst), 2):
lst[i] = lst[i] * 2
if lst[i] > 9:
lst[i] -= 9
s2 = sum(lst[1:len(lst):2])
s2 = sum(lst[1::2])

if (s1 + s2) % 10 == 0:
return True
return False
return (s1 + s2) % 10 == 0

# Defining my luhn algorithm for creating a new card number
def luhn(self):

"""
Generate a valid card number using Luhn algorithm.

Returns:
str: Valid card number.
"""
lst2 = [int(x) for x in self.card]
lst3 = lst2[:]

for i in range(len(lst3)):
if i % 2 == 0:
lst3[i] = lst3[i] * 2
else:
lst3[i] = lst3[i]
for i in range(0, len(lst3), 2):
lst3[i] *= 2

for i in range(len(lst3)):
if lst3[i] > 9:
lst3[i] -= 9
lst3 = [x - 9 if x > 9 else x for x in lst3]

tot = sum(lst3)
count_sum = 0
while True:
if (tot + count_sum) % 10 == 0:
break
else:
count_sum += 1
count_sum = (10 - tot % 10) % 10

lst2.append(count_sum)
self.card = (''.join(map(str, lst2)))
self.card = ''.join(map(str, lst2))

return self.card

def menu(self):
"""Display main menu and handle user choices."""
while True:
print("""\n1. Create an account
2. Log into account
Expand All @@ -182,5 +198,6 @@ def menu(self):
print("Invalid input")


# Create a Card object and start the program
card = Card()
card.menu()
card.menu()