Skip to content

Conversation

@abelrodriguez
Copy link
Contributor

This PR fixes/implements the following bugs/features:

  • Feature: Connect from an oleobject using COM connection

What existing problem does the pull request solve?

To connect from an oleobject from VB 6 or Powerbuilder, we need a
constructor without parameters since it is not possible to parameterize
it.

In addition, COM connections are not compatible with generic collections,
throws an exception "function name not found".

This can be solved by eliminating the generic collections, since it would
not affect the current functionality, and creating a constructor without
parameters. Subsequently, the QRCodeData object that is currently assigned
in the constructor with parameters, would be added manually with
SetQRCodeData function

Closing issues

closes #108

…der)

To connect from an oleobject from VB 6 or Powerbuilder, we need a
constructor without parameters since it is not possible to parameterize
it.

In addition, COM connections are not compatible with generic collections,
throws an exception "function name not found".

This can be solved by eliminating the generic collections, since it would
not affect the current functionality, and creating a constructor without
parameters. Subsequently, the QRCodeData object that is currently assigned
in the constructor with parameters, would be added manually with
SetQRCodeData function

Resolves: Shane32#108
@codebude
Copy link
Collaborator

codebude commented Mar 7, 2018

Hi @abelrodriguez ,

thanks for this PR. It's just incredible - I discussed about implementing an COM Interop interface for QRCoder round about a hour ago with a colleague - and then came your PR...

Just let me ask one, two questions before merging:

  • Why did you remove the Dispose methods? ( Which where added in this PR: Update QRCode.cs #18 )
  • Do you plan to deliver another PR for the PayloadGenerator class? (Otherwise I'll add it to my "to do"-list. ;-) )

@abelrodriguez
Copy link
Contributor Author

Hi @codebude,

I removed the Dispose methods because thought it would be more efficient integrate it in AbstractQRCode but I think I had an error on interface implementation/declaration.

About second question... =) At first sight, I think it could be complex. Maybe we have to do a code restructuring to extract each class declared within static class PayloadGenerator. So, for now, I don´t plan to deliver another PR unless you need it. In that case, I promise to deliver those changes.

Thank you very much for considering my PR.

@codebude codebude merged commit e65145f into Shane32:master Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connect from an oleobject using COM connection (VB 6, Powerbuilder...)

2 participants