Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.2 - complete dynamic properties for library/Zend #291

Merged
merged 26 commits into from
Nov 29, 2022
Merged

PHP 8.2 - complete dynamic properties for library/Zend #291

merged 26 commits into from
Nov 29, 2022

Conversation

hungtrinh
Copy link

Complete "What Next" section in PR #289

Fix bug PHP 8.2: Dynamic Properties are deprecated' for library/Zend/**

@hungtrinh hungtrinh changed the title PHP 82 complete dynamic properties for library PHP 8.2 - complete dynamic properties for library Nov 28, 2022
@hungtrinh hungtrinh changed the title PHP 8.2 - complete dynamic properties for library PHP 8.2 - complete dynamic properties for library/Zend Nov 28, 2022
@hungtrinh hungtrinh mentioned this pull request Nov 28, 2022
Closed
glensc
glensc reviewed Nov 28, 2022
View reviewed changes
library/Zend/View/Helper/Placeholder/Registry.php Outdated
@@ -39,6 +39,13 @@
*/
class Zend_View_Helper_Placeholder_Registry
{
/**
* View object
*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove trailing whitespace

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing space is still there

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, I fixed here hungtrinh@f269ec7

glensc
glensc reviewed Nov 28, 2022
View reviewed changes
library/Zend/Form/DisplayGroup.php Outdated
@@ -29,6 +29,13 @@
*/
class Zend_Form_DisplayGroup implements Iterator,Countable
{
/**
* Element Id
*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove trailing space

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing space is still there

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed here hungtrinh@28b4a91

@hungtrinh hungtrinh force-pushed the php82-complete-dynamic-properties-for-library branch from 87bd9e4 to 55227b4 Compare November 29, 2022 06:30
@hungtrinh hungtrinh marked this pull request as draft November 29, 2022 06:52
@hungtrinh
Add missing properties to classes Zend/Amf/*
95f34a6 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Amf/AllTests.php
@hungtrinh
Removed code call undefined method
7965be5 
Zend_Cloud_Infrastructure_Adapter_Ec2Test::main()

Have two options to fix similar issue:
- Remove code call undefine method xxxTest::main(). (simple and don't have any bad effect)
- Make sure on top of file xxxTest.php define const like that https://github.com/Shardj/zf1-future/blob/713e3f4e3a8779a7dd983b17260949cf4adec99d/tests/Zend/LoaderTest.php#L29-L31. Body of class xxxTest has method main() like that https://github.com/Shardj/zf1-future/blob/713e3f4e3a8779a7dd983b17260949cf4adec99d/tests/Zend/LoaderTest.php#L78-L82
@hungtrinh
Add missing properties to classes Zend/Cloud/*
6b65e7a 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Cloud/Infrastructure/Adapter/Ec2Test.php
@hungtrinh
Add missing properties to classes libray/Zend/Crypt/*
a78630a 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Crypt/Rsa/AllTests.php
@hungtrinh
Add missing properties to classes Zend/Db/*
97fcb3d 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Db/AllTests.php
@hungtrinh
Add missing properties to classes Zend/EventManager/*
a011094 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/EventManager/AllTests.php
@hungtrinh
Add missing properties to classes Zend/Filter/*
3d31919 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Filter/AllTests.php
@hungtrinh hungtrinh force-pushed the php82-complete-dynamic-properties-for-library branch from 55227b4 to 77b6005 Compare November 29, 2022 07:56
@hungtrinh hungtrinh marked this pull request as ready for review November 29, 2022 08:11
@hungtrinh
Add missing properties to classes Zend/Form/*
28b4a91 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Form/AllTests.php
@hungtrinh
Add missing properties to classes Zend/Gdata/*
fe8b2a4 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Gdata/SpreadsheetsTest.php
@hungtrinh
Add missing properties to classes Zend/Http/*
f65433f 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Http/AllTests.php
@hungtrinh
Add missing properties to classes Zend/Json/*
a49a5e3 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Json/AllTests.php
@hungtrinh
Add missing properties to classes Zend/Loader/*
75272cd 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Loader/AllTests.php
@hungtrinh
Add missing properties to classes Zend/Mail/*
920708a 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Mail/AllTests.php
@hungtrinh
Add missing properties to classes Zend/View/*
f269ec7 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/View/AllTests.php
@hungtrinh
Add missing properties to classes Zend/TimeSync/*
3e7760d 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/TimeSyncTest.php
@hungtrinh
Removed code call undefined method
1820602 
Zend_XmlRpc_ServerTest::main()

Have two options to fix similar issue:
- Remove code call undefine method xxxTest::main(). (simple and don't have any bad effect)
- Make sure on top of file xxxTest.php define const like that https://github.com/Shardj/zf1-future/blob/713e3f4e3a8779a7dd983b17260949cf4adec99d/tests/Zend/LoaderTest.php#L29-L31. Body of class xxxTest has method main() like that https://github.com/Shardj/zf1-future/blob/713e3f4e3a8779a7dd983b17260949cf4adec99d/tests/Zend/LoaderTest.php#L78-L82
@hungtrinh
Add missing properties to classes Zend/XmlRpc/*
9616102 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/XmlRpc/ServerTest.php
hungtrinh and others added 3 commits November 30, 2022 00:11
@hungtrinh
Add missing properties to classes Zend/Pdf/*
b36d4d3 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Pdf/AllTests.php
@hungtrinh
Add missing properties to class Zend_Service_Exception
b357d44 
PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated

Root cause here: https://github.com/Shardj/zf1-future/blob/713e3f4e3a8779a7dd983b17260949cf4adec99d/library/Zend/Service/Audioscrobbler.php#L204-L206

Verified by:
docker run -u "$(id -u):$(id -g)" -v $(pwd):$(pwd) -w $(pwd) -t --rm php:8.2-rc-cli-alpine -d memory_limit=-1 ./bin/phpunit -v --bootstrap tests/TestHelper.php tests/Zend/Service/Audioscrobbler/AllTests.php
@glensc @hungtrinh
Fix indirect typo
ae901d0
@hungtrinh hungtrinh force-pushed the php82-complete-dynamic-properties-for-library branch from 77b6005 to ae901d0 Compare November 29, 2022 17:14
@glensc glensc merged commit 66f96b4 into Shardj:master Nov 29, 2022
@glensc
Copy link
Collaborator

glensc commented Nov 29, 2022

Thanks. Hard work it is!

@falkenhawk falkenhawk mentioned this pull request May 18, 2023
Merged
falkenhawk pushed a commit to zf1s/zf1 that referenced this pull request May 18, 2023
@hungtrinh @falkenhawk
Add missing properties to library classes
1f269dc 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zf1 that referenced this pull request Jan 3, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
2970b03 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-amf that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
bc4bbe8 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-cloud that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
57a3bb2 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-crypt that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
4fcafcf 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-db that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
9ee1985 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-eventmanager that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
798cbf0 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-filter that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
4df9a08 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-form that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
3e3b421 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-gdata that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
3a7c744 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-http that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
1d13efe 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-json that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
f2e8445 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-loader that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
cf657dc 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-mail that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
2d101f8 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-pdf that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
cb5bb00 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-search-lucene that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
608bae0 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-service that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
0a56387 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-service-amazon that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
eaee021 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-service-yahoo that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
471465b 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-timesync that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
526409b 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-tool that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
d19ea6d 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-view that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
67d4310 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
falkenhawk pushed a commit to zf1s/zend-xmlrpc that referenced this pull request Jan 4, 2024
@hungtrinh @falkenhawk
Add missing properties to library classes
9fba4fa 
Ported from Shardj/zf1-future#291

PHP 8.2: Dynamic Properties are deprecated fix

Reference: https://php.watch/versions/8.2/dynamic-properties-deprecated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glensc glensc glensc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hungtrinh @glensc