Make NewPipe Extractor really old Android compatible #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ShareASmile
commented
Jan 26, 2025
•
ShareASmile
commented
- I carefully read the contribution guidelines and agree to them.
- I have tested the API against NewPipe.
- I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.
i.e. without needing to pass through the conference/channel extractor This was needed because clients (like NewPipe) might rely on link handlers to hold as little data as possible, since they might be kept around for long or passed around in system transactions, so this commit allows obtaining a standalone link handler that does not hold a JsonObject within itself.
This caused problems in NewPipe, because extractors are not serializable, and well, keeping references to them is a bad idea anyway.
It’s not obvious that the function will fail in some cases and throw an `IllegalArgumentException`. So instead of just failing if parsing fails, return an Optional that all callers have to decide what to do (e.g. the YoutubeExtractor can just ignore the locale in that case, like it does with most other fields in the json if they are unexpected).
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Implement PeerTubeStreamExtractor.getFrames()
Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.10.0 to 5.10.2. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.10.0...r5.10.2) --- updated-dependencies: - dependency-name: org.junit:junit-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…e/org.junit-junit-bom-5.10.2 Bump org.junit:junit-bom from 5.10.0 to 5.10.2
…b_actions/actions/cache-4 Bump actions/cache from 3 to 4
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…b_actions/actions/upload-artifact-4 Bump actions/upload-artifact from 3 to 4
Search did not return no item at all, causing a NothingFoundException. New search query yields three items on first page
Fix some failing unit tests and detect new account termination messages for YouTube
…on-npe Make getCommentText @nonnull
…handler [MediaCCC] Allow obtaining channel tab link handler
[PeerTube] Add support for PeerTube v6 features
…rn-optional LocaleCompat.forLanguageTag: return Optional if parsing fails
Also improve current comments code by removing outdated comment renderer data.
Also refactor descriptions parsing.
Remove unneeded isClose field, and make constants private
…action [YouTube] Support new comments data
…eekbar_preview_crash Add documentation for faulty framesets
Wrong methods were used to access and extract the thumbnails' data. This has been fixed with this commit.
…ails-extraction [YouTube] Fix Shorts' thumbnails extraction in their channel tab
This method will be used in more places such as the new playlist item data. Support for a new icon used in artist channels has been also added.
This new data type, A/B tested or rolled out at the time the changes are commited, is present on multiple surfaces.
Extractor.pageFetched -> Extractor.isPageFetched Stream.equalStats(Stream) is renamed to Stream.areStatsEqual(Stream) Stream.getBitrate() is renamed to Stream.getBitRate()
…ms-extraction [YouTube] Add support for new playlist items data structure
This reverts commit 0de2241.
…ure-branch Revert "Refactored Identifiers"
Implement a max number of requests per minute to prevent hitting reate limits and triggering ReCaptchaExceptions. This slows down the RecordingDownloader significantly and can be adjusted if needed. A request ist retried once when facing a ReCaptchaException.
[tests] Update user agent
…youtube/YoutubeParsingHelper.java Co-authored-by: Stypox <stypox@pm.me>
[YouTube] update iOS client, add visitor data to requests
Remove the scheduled run
Bump [com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle) from 10.4 to 10.12.2.
Base64 is not available on such Androids too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.