Updates from gojek/courier-android #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reset state when optimal keepalive is failed * Update keepalive handling logic on failure * Reset state on network change without connected check * Fix unit tests
* Improved tls handling and add support for alpn * removed socket factory from connection config * applied spotless * added expeirmental config for new ssl flow * dump public api * corrected sample app * fixed test failures * removed redundant code and required checks * fixed review comments * converted paho to java module * updated docs * add back required checks * fixed broker docs link Co-authored-by: Anubhav Gupta <anubhav.gupta@go-jek.com>
Co-authored-by: Anubhav Gupta <anubhav.gupta@go-jek.com>
In order to fix vulnerability reported on https://security.snyk.io/vuln/SNYK-JAVA-COMGOOGLECODEGSON-1730327
* Add topic & content-type in message adapter
# Conflicts: # mqtt-client/src/main/java/com/gojek/mqtt/connection/config/v3/ConnectionConfig.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/ConnectionSpec.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/MqttAsyncClient.java # paho/src/main/java/in/mohalla/paho/client/mqttv3/MqttConnectOptions.java # paho/src/main/java/in/mohalla/paho/client/mqttv3/Protocol.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/SuppressSignatureCheck.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/Util.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/SSLNetworkModuleV2.java # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/Android10Platform.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/AndroidPlatform.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/BouncyCastlePlatform.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/ConscryptPlatform.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/Jdk8WithJettyBootPlatform.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/Jdk9Platform.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/OpenJSSEPlatform.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/Platform.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/android/Android10SocketAdapter.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/android/AndroidCertificateChainCleaner.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/android/AndroidSocketAdapter.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/android/BouncyCastleSocketAdapter.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/android/ConscryptSocketAdapter.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/android/DeferredSocketAdapter.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/android/SocketAdapter.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/platform/android/StandardAndroidSocketAdapter.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/tls/BasicCertificateChainCleaner.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/tls/BasicTrustRootIndex.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/tls/CertificateChainCleaner.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/tls/CipherSuite.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/tls/TlsVersion.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/tls/TrustRootIndex.kt # paho/src/main/java/in/mohalla/paho/client/mqttv3/internal/websocket/WebSocketSecureNetworkModuleV2.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest changes v0.1.6