Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color picker has weird padding #670

Closed
nilsreichardt opened this issue May 18, 2023 · 0 comments · Fixed by #671
Closed

Color picker has weird padding #670

nilsreichardt opened this issue May 18, 2023 · 0 comments · Fixed by #671
Labels
bug Something isn't working. feature: groups Groups umbrella term for courses and classes. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). ui / ux

Comments

@nilsreichardt
Copy link
Member

Demo

IMG_19BB8027D72F-1

Used commit: 05b6009
@nilsreichardt nilsreichardt added bug Something isn't working. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). ui / ux feature: groups Groups umbrella term for courses and classes. labels May 18, 2023
@nilsreichardt nilsreichardt mentioned this issue May 18, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 2, 2023
@nilsreichardt
Fix course color picker (#671)
df90608 
As in #670 shown was the course color picker broken. The issue for this
was that `size` was null for the default colors.

I also added a golden test to verify that the dialog is rendered
correctly.


![image](https://github.com/SharezoneApp/sharezone-app/assets/24459435/954f3d2a-e32a-45b3-a9c8-02ce53b1efaf)

Fixes #670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. feature: groups Groups umbrella term for courses and classes. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). ui / ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix course color picker SharezoneApp/sharezone-app
1 participant
@nilsreichardt