Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change _DashboardPageFAB from StatefulWidget to StatelessWidget #1123

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

nilsreichardt
Copy link
Member

The widget _DashboardPageFAB was a StatefulWidget but never used setState or similar. It could also maybe fix the issue with the context that we have tracked in Crashlytics.

Related to: flutter/flutter#135389

@github-actions github-actions bot added ui / ux w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.). labels Oct 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Visit the preview URL for this PR (updated for commit e485636):

https://sharezone-test--pr1123-change-dashboardpag-h25vupf1.web.app

(expires Sat, 14 Oct 2023 13:07:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit b0c4c97 Oct 11, 2023
21 checks passed
@nilsreichardt nilsreichardt deleted the change-_DashboardPageFAB-state-widget branch October 11, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui / ux w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants