Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dart:io file code with package:file. #1132

Merged
merged 19 commits into from
Oct 22, 2023
Merged

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Oct 20, 2023

We use package:file to create a layer of indirection (FileSystem) so that code can be tested more easily (similar to #1131).
Additionally I created a Context class, just so that one doesn't have to pass many parameters to all Command classes.

Requires #1130
Requires #1131

@github-actions github-actions bot added platform: macos platform: web platform: ios platform: android testing sharezone cli feature: comments Comment on contents (homeworks, info sheets) to e.g. ask for clarifications on a task. dependencies Changing, updating, adding or removing one or more dependencies. labels Oct 20, 2023
@Jonas-Sander Jonas-Sander marked this pull request as ready for review October 20, 2023 22:03
@Jonas-Sander
Copy link
Collaborator Author

@nilsreichardt Can be reviewed now

Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Oct 22, 2023
Merged via the queue into main with commit 780288c Oct 22, 2023
21 checks passed
@Jonas-Sander Jonas-Sander deleted the sz-cli-file-package branch October 22, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changing, updating, adding or removing one or more dependencies. feature: comments Comment on contents (homeworks, info sheets) to e.g. ask for clarifications on a task. platform: android platform: ios platform: macos platform: web sharezone cli testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants