-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dart:io
file code with package:file
.
#1132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `sz exec` command runs a custom command for all / multiple packages. E.g. `sz exec -- fvm dart fix --apply`. The flags `onlyDart` and `onlyFlutter` can be used to run the command only in pure Dart or only Flutter packages. E.g. `sz exec -onlyDart -- fvm dart pub get`.
github-actions
bot
added
platform: macos
platform: web
platform: ios
platform: android
testing
sharezone cli
feature: comments
Comment on contents (homeworks, info sheets) to e.g. ask for clarifications on a task.
dependencies
Changing, updating, adding or removing one or more dependencies.
labels
Oct 20, 2023
@nilsreichardt Can be reviewed now |
nilsreichardt
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Changing, updating, adding or removing one or more dependencies.
feature: comments
Comment on contents (homeworks, info sheets) to e.g. ask for clarifications on a task.
platform: android
platform: ios
platform: macos
platform: web
sharezone cli
testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
package:file
to create a layer of indirection (FileSystem
) so that code can be tested more easily (similar to #1131).Additionally I created a
Context
class, just so that one doesn't have to pass many parameters to allCommand
classes.Requires #1130
Requires #1131