Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move files #1133

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Move files #1133

merged 5 commits into from
Oct 25, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Oct 25, 2023 •
edited
Loading

I moved several files around.

Most notably I moved all files out of app/lib/pages and app/lib/blocs into their designated domain subfolder (e.g. app/lib/pages/settings/settings_page.dart to app/lib/settings/settings_page) and thus deleted app/lib/pages and app/lib/blocs.

Beforehand we were already mix and matching both approaches (top level pages/bloc folder and domain folders), now we use mostly domain folders (except util, widgets and main).

@github-actions github-actions bot added feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. platform: web feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: notifications Push-Notifications and In-App-Notifications. legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: information sheet Information sheets are posted to courses as a way to announce information. ui / ux feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. feature: attachments Attachments are files that can be added to homeworks or information sheets. feature: holidays feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups Groups umbrella term for courses and classes. feature: navigation Navigation inside the app (e.g. switching to a different screen). testing feature: onboarding The steps (setting username, courses, etc.) after creating a new account. feature: group permissions Group admins can set what permissions different course members can do (e.g. only read content). feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. user: teacher user: parent feature: comments Comment on contents (homeworks, info sheets) to e.g. ask for clarifications on a task. user: pupil / student feature: analytics Includes everything that is related to analytics and usage tracking labels Oct 25, 2023
@github-actions github-actions bot added feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.). labels Oct 25, 2023
@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit bbc0c01):

https://sharezone-test--pr1133-move-files-obcpxdrf.web.app

(expires Sat, 28 Oct 2023 16:07:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander Jonas-Sander marked this pull request as ready for review October 25, 2023 16:02
nilsreichardt
nilsreichardt approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 90d4bd3 Oct 25, 2023
33 checks passed
@Jonas-Sander Jonas-Sander deleted the move-files branch October 25, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
feature: analytics Includes everything that is related to analytics and usage tracking feature: attachments Attachments are files that can be added to homeworks or information sheets. feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. feature: comments Comment on contents (homeworks, info sheets) to e.g. ask for clarifications on a task. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: group permissions Group admins can set what permissions different course members can do (e.g. only read content). feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: holidays feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. feature: information sheet Information sheets are posted to courses as a way to announce information. feature: navigation Navigation inside the app (e.g. switching to a different screen). feature: notifications Push-Notifications and In-App-Notifications. feature: onboarding The steps (setting username, courses, etc.) after creating a new account. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. platform: web testing ui / ux user: parent user: pupil / student user: teacher w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonas-Sander @nilsreichardt