-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use package:patrol
for Android e2e tests.
#1137
Conversation
Visit the preview URL for this PR (updated for commit c31de56): https://sharezone-test--pr1137-patrol-e2e-tests-rzzd2cae.web.app (expires Thu, 09 Nov 2023 11:28:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
e0393e9
to
5103da3
Compare
This reverts commit 0616622.
package:patrol
for e2e tests.package:patrol
for Android e2e tests.
@nilsreichardt Ready for review. I couldn't get iOS set up, so for now I left it as is. Also the macOS job seems to be making problems, do you know how it can be fixed? |
# The secrets already contain the base64 encoded values. We don't | ||
# encode them in the workflow file, because we could easily leak the | ||
# base64 encoded version in logs. | ||
USER_1_EMAIL_BASE64: ${{ secrets.INTEGRATION_TEST_USER_1_EMAIL_DART_DEFINE_BASE64 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After merging this PR, we can delete INTEGRATION_TEST_USER_1_EMAIL_DART_DEFINE_BASE64
from our secrets, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Even, if we can get Patrol running for iOS, we can't re-use the tests for Android because on iOS you can't clear the app state after each test. Because of our sign-out bug, we still need on iOS one large e2e test. |
Use
package:patrol
for integration/e2e tests for Android.The biggest benefit is that each test can run from a completely clean state, which is not possible with the
integration_test
package. Because of this we shouldn't have the issues with e.g. the auth state being kept for each test (or logging out and back in which breaks stuff).For other platforms I kept our old tests (renamed to
integration_test/integration_test_old.dart
):From https://patrol.leancode.co/:
Command to running the tests: