Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go_router to our website and use path URL strategy instead of hash URL strategy #1184

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

nilsreichardt
Copy link
Member

This PR adds go_router as a navigation package to our website. This is required for better query parameter passing (used for the "parents buy their children Sharezone Plus" feature. Additionally, this PR changes the URL strategy from hash to path (sharezone.net/#/ to sharezone.net/).

@github-actions github-actions bot added ci/cd legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. dependencies Changing, updating, adding or removing one or more dependencies. website labels Dec 9, 2023
Copy link

github-actions bot commented Dec 9, 2023

Visit the preview URL for this PR (updated for commit b6f3bbf):

https://sharezone-website-dev--pr1184-add-go-router-k0ebbls0.web.app

(expires Tue, 12 Dec 2023 18:14:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@nilsreichardt nilsreichardt added this pull request to the merge queue Dec 9, 2023
Merged via the queue into main with commit 22284b3 Dec 9, 2023
27 checks passed
@nilsreichardt nilsreichardt deleted the add-go-router branch December 9, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd dependencies Changing, updating, adding or removing one or more dependencies. legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants