Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move AppFunctionsDialog/Sheet from sharezone_widgets to app_functions package #1189

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Move AppFunctionsDialog/Sheet from sharezone_widgets to app_functions package #1189

merged 2 commits into from
Dec 9, 2023

Conversation

nilsreichardt
Copy link
Member

To remove the dependencies with native components (app_functions dependents on cloud_firestore) I moved showAppFunctionStateDialog() and showAppFunctionStateSheet() into the app_functions package.

@github-actions github-actions bot added ui / ux feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups Groups umbrella term for courses and classes. dependencies Changing, updating, adding or removing one or more dependencies. labels Dec 9, 2023
@nilsreichardt nilsreichardt added the refactoring Restructuring and cleaning up existing code without changing its existing behaviour. label Dec 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 03944fb):

https://sharezone-website-dev--pr1189-move-app-functions-s-98p2g8mo.web.app

(expires Tue, 12 Dec 2023 21:54:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 03944fb):

https://sharezone-test--pr1189-move-app-functions-s-0q4by66q.web.app

(expires Tue, 12 Dec 2023 21:55:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@github-actions github-actions bot added feature: holidays feature: analytics Includes everything that is related to analytics and usage tracking labels Dec 9, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Dec 9, 2023
Merged via the queue into main with commit f2f050a Dec 9, 2023
28 checks passed
@nilsreichardt nilsreichardt deleted the move-app-functions-sheet-and-dialog branch December 9, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
dependencies Changing, updating, adding or removing one or more dependencies. feature: analytics Includes everything that is related to analytics and usage tracking feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: holidays refactoring Restructuring and cleaning up existing code without changing its existing behaviour. ui / ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsreichardt @Jonas-Sander