Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract PlatformCheck from sharezone_utils to a separate platform_check package #1190

Merged
merged 4 commits into from
Dec 10, 2023
Merged

Extract PlatformCheck from sharezone_utils to a separate platform_check package #1190

merged 4 commits into from
Dec 10, 2023

Conversation

nilsreichardt
Copy link
Member

I extracted the PlatformCheck stuff from sharzeone_utils in it's own package with to goal to remove sharezone_utils from sharezone_widgets.

@github-actions github-actions bot added code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. platform: web feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: notifications Push-Notifications and In-App-Notifications. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). ui / ux feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. feature: groups Groups umbrella term for courses and classes. feature: navigation Navigation inside the app (e.g. switching to a different screen). testing feature: onboarding The steps (setting username, courses, etc.) after creating a new account. feature: group permissions Group admins can set what permissions different course members can do (e.g. only read content). feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. dependencies Changing, updating, adding or removing one or more dependencies. feature: feedback Users can send us feedback to improve the app. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.). labels Dec 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 7f0a2a0):

https://sharezone-website-dev--pr1190-extract-platform-che-h5vk5b12.web.app

(expires Wed, 13 Dec 2023 09:51:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 7f0a2a0):

https://sharezone-test--pr1190-extract-platform-che-a9zqg8qt.web.app

(expires Wed, 13 Dec 2023 09:52:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt added this pull request to the merge queue Dec 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2023
@github-actions github-actions bot added the feature: analytics Includes everything that is related to analytics and usage tracking label Dec 10, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Dec 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Dec 10, 2023
Merged via the queue into main with commit d692018 Dec 10, 2023
28 checks passed
@nilsreichardt nilsreichardt deleted the extract-platform-check branch December 10, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. dependencies Changing, updating, adding or removing one or more dependencies. feature: analytics Includes everything that is related to analytics and usage tracking feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. feature: feedback Users can send us feedback to improve the app. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: group permissions Group admins can set what permissions different course members can do (e.g. only read content). feature: groups Groups umbrella term for courses and classes. feature: holidays feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. feature: navigation Navigation inside the app (e.g. switching to a different screen). feature: notifications Push-Notifications and In-App-Notifications. feature: onboarding The steps (setting username, courses, etc.) after creating a new account. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. platform: web testing ui / ux w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsreichardt @Jonas-Sander