Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove google_sign_in_dartio #1198

Merged
merged 3 commits into from
Dec 25, 2023
Merged

Remove google_sign_in_dartio #1198

merged 3 commits into from
Dec 25, 2023

Conversation

nilsreichardt
Copy link
Member

The google_sign_in package supports since v6.2.0 Google Sign In for macOS (flutter/packages#5600). Therefore, the no need for the google_sign_in_dartio package anymore. Additionally, this PR adds Google Sign In for our dev environment (besides prod).

Closes #1178

@github-actions github-actions bot added platform: macos feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. dependencies Changing, updating, adding or removing one or more dependencies. labels Dec 15, 2023
Copy link

github-actions bot commented Dec 15, 2023

Visit the preview URL for this PR (updated for commit 304ad42):

https://sharezone-website-dev--pr1198-remove-google-sign-d-t0zibapy.web.app

(expires Thu, 28 Dec 2023 14:13:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

Copy link

github-actions bot commented Dec 15, 2023

Visit the preview URL for this PR (updated for commit 304ad42):

https://sharezone-test--pr1198-remove-google-sign-d-dpif5e0b.web.app

(expires Thu, 28 Dec 2023 14:14:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt
Copy link
Member Author

I have no idea why flutter pub get returns a different result compared to safe-app-ci/analyze and cli-ci/analyze 🤔

@nilsreichardt nilsreichardt merged commit bc3f187 into main Dec 25, 2023
27 of 28 checks passed
@nilsreichardt nilsreichardt deleted the remove-google-sign-dartio branch December 25, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changing, updating, adding or removing one or more dependencies. feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. platform: macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace google_sign_in_dartio with google_sign_in
2 participants