Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove timestampFromDateTime method #1235

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Remove timestampFromDateTime method #1235

merged 1 commit into from
Jan 6, 2024

Conversation

nilsreichardt
Copy link
Member

It's not necessary to convert a DateTime to a Timestamp. The cloud_firestore package already does this for you. The background for removing this method is because I want to get rid of the cloud_firestore dependency in firebase_helper.dart to avoid having the Firebase dependencies on our website.

@github-actions github-actions bot added feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. feature: groups Groups umbrella term for courses and classes. feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. labels Jan 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

Visit the preview URL for this PR (updated for commit 2234f9f):

https://sharezone-website-dev--pr1235-remove-timestampfrom-be7w9tuy.web.app

(expires Tue, 09 Jan 2024 16:53:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

Visit the preview URL for this PR (updated for commit 2234f9f):

https://sharezone-test--pr1235-remove-timestampfrom-9w90hxi3.web.app

(expires Tue, 09 Jan 2024 16:54:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt added this pull request to the merge queue Jan 6, 2024
@nilsreichardt nilsreichardt removed this pull request from the merge queue due to a manual request Jan 6, 2024
@nilsreichardt nilsreichardt merged commit 90a401d into main Jan 6, 2024
27 checks passed
@nilsreichardt nilsreichardt deleted the remove-timestampFromDateTime-method branch January 6, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: groups Groups umbrella term for courses and classes. feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsreichardt @Jonas-Sander