Add strike through animation to homework

[nilsreichardt]

v.mp4

ToDos:

• Add option to hide strike through on completed list?
• Strike through for homework with submissions
• Sometimes the homework doesn't disappear from the completed list
• Update tests?
• Is there an option to display the animation without delaying the database call (semi fixed)
• Support dark mode

[coderabbitai]

Important

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[nilsreichardt]

@Jonas-Sander WDYT?

[github-actions]

Visit the preview URL for this PR (updated for commit e44959a):

https://sharezone-test--pr1266-strike-through-zke4xtlo.web.app

_{(expires Sat, 19 Oct 2024 19:43:39 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b}

[Jonas-Sander]

I like the idea overall. I think:

• the animation speed at the start should be faster. In the video it ramps up gradually. A "quicker" curve should fit better I guess.
• I think on the completed page they shouldn't be crossed through at all since it makes it hard to read.
• Not sure if the abbreviation should get crossed through (or maybe the strike should cover the whole circle. not just the text)

[Sharezone-Admin]

⬇️ Builds generated by Codemagic for commit e44959a ⬇️

Note: Only Sharezone team members are able to install the iOS app.

iOS		Android
Download link		Download link

_{(expires Fri, 15 Nov 2024 19:52:40 GMT)
Codemagic build: 67101697f061c5fe4ad9dfcb; comment generated with Codemagic App Preview}

[nilsreichardt]

We need here to make a trade-off and reduce the maxLines from 2 to 1. I think it's okay since you normally know what the homework was when reading the first line. Otherwise, you just press on the homework and you get the full title.

[nilsreichardt]

the animation speed at the start should be faster. In the video it ramps up gradually. A "quicker" curve should fit better I guess.

Changed it to Curve.ease, should be better now 👍

I think on the completed page they shouldn't be crossed through at all since it makes it hard to read.

Removed it - I was also unsure about show it there.

Not sure if the abbreviation should get crossed through (or maybe the strike should cover the whole circle. not just the text)

I kept it because striking the whole circle looked weird and not striking it also looked weird because everything gets struck expect the abbreviation on the left.

[Jonas-Sander]

I'd personally would like the animation to be a bit quicker still, but I'm totally okay with the current state as well. LGTM!