Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI/CD pipelines from macos-13 to macos-14 #1288

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/alpha.yml
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ jobs:
--release-notes "$LAST_COMMIT_MESSAGE"

deploy-alpha-ios-app:
runs-on: macos-13
runs-on: macos-14
timeout-minutes: 120
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
Expand Down Expand Up @@ -263,7 +263,7 @@ jobs:
--export-options-plist=$HOME/export_options.plist

deploy-alpha-macos-app:
runs-on: macos-13
runs-on: macos-14
timeout-minutes: 60
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/beta.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
# We skip the deployment if no changelog is provided because we assume that
# nothing has changed in the iOS app and therefore no new version is needed.
if: github.event.inputs.ios-changelog != ''
runs-on: macos-13
runs-on: macos-14
timeout-minutes: 120
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
Expand Down Expand Up @@ -210,7 +210,7 @@ jobs:
# We skip the deployment if no changelog is provided because we assume that
# nothing has changed in the macOS app and therefore no new version is needed.
if: github.event.inputs.macos-changelog != ''
runs-on: macos-13
runs-on: macos-14
timeout-minutes: 60
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
Expand Down
15 changes: 5 additions & 10 deletions .github/workflows/integration_tests_app_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -170,12 +170,7 @@ jobs:

ios-integration-test:
needs: changes
# We are using macos-12 instead macos-13 because with macos-13 we have job
# times of 40 - 120 minutes.
#
# Before switching back to macos-13, we should check if the job times are
# still that long by running the job with a matrix (3 runs).
runs-on: macos-12
runs-on: macos-14
if: ${{ needs.changes.outputs.changesFound == 'true' }}
timeout-minutes: 60
steps:
Expand All @@ -190,16 +185,16 @@ jobs:
flutter-version: ${{ steps.fvm-config-action.outputs.FLUTTER_VERSION }}
channel: ${{ steps.fvm-config-action.outputs.FLUTTER_CHANNEL }}

# Because macos-12 doesn't have Metal support, we need to disable Impeller
# https://github.com/flutter/flutter/issues/126768
# Because GitHub Action runners don't have Metal support, we need to
# disable Impeller https://github.com/flutter/flutter/issues/126768
- name: Disable Impeller
working-directory: app/ios/Runner
run: /usr/libexec/PlistBuddy -c "Add :FLTEnableImpeller bool false" Info.plist

- uses: futureware-tech/simulator-action@427329dea8e4d6417cba1273ebb5c9ad4720082d
id: simulator
with:
model: "iPhone 13"
model: "iPhone 14"

- name: Run integration tests
working-directory: app
Expand Down Expand Up @@ -269,7 +264,7 @@ jobs:
# macOS app.
macos-build-test:
needs: changes
runs-on: macos-13
runs-on: macos-14
if: ${{ needs.changes.outputs.changesFound == 'true' }}
timeout-minutes: 60
defaults:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
# We skip the deployment if no changelog is provided because we assume that
# nothing has changed in the iOS app and therefore no new version is needed.
if: github.event.inputs.ios-changelog != ''
runs-on: macos-13
runs-on: macos-14
timeout-minutes: 120
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
Expand Down Expand Up @@ -212,7 +212,7 @@ jobs:
# We skip the deployment if no changelog is provided because we assume that
# nothing has changed in the macOS app and therefore no new version is needed.
if: github.event.inputs.macos-changelog != ''
runs-on: macos-13
runs-on: macos-14
timeout-minutes: 60
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
Expand Down
Loading