Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sz build web in web-app preview job and add preview stage to it. #1290

Merged
merged 29 commits into from
Feb 7, 2024

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Feb 6, 2024

Use sz build web in web-app preview job and add preview stage to it.

Together with #1291 this will display a "PREVIEW" banner for all previews.

Since this uses pull_request_target one can't see it in the preview here. I checked manually though (by overriding pull_request_target with pull_request)

Copy link
Contributor

coderabbitai bot commented Feb 6, 2024

Warning

Rate Limit Exceeded

@Jonas-Sander has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 26 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 12008af and 0eb2c93.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@Jonas-Sander Jonas-Sander changed the title Web app preview stage Add a "preview" deployment stage for the web app. Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Visit the preview URL for this PR (updated for commit 0eb2c93):

https://sharezone-test--pr1290-web-app-preview-stag-33swv0dk.web.app

(expires Sat, 10 Feb 2024 14:41:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@github-actions github-actions bot added the ci/cd label Feb 6, 2024
@Jonas-Sander Jonas-Sander changed the title Add a "preview" deployment stage for the web app. Add a "preview" stage for sz build web and use it in GitHub Actions. Feb 7, 2024
@Jonas-Sander Jonas-Sander changed the title Add a "preview" stage for sz build web and use it in GitHub Actions. Use sz build web in web-app preview job and add preview stage to it. Feb 7, 2024
@Jonas-Sander Jonas-Sander marked this pull request as ready for review February 7, 2024 14:36
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit c42ca59 Feb 7, 2024
28 checks passed
@Jonas-Sander Jonas-Sander deleted the web-app-preview-stage branch February 7, 2024 18:49
github-merge-queue bot pushed a commit that referenced this pull request Feb 7, 2024
This replaces the `AlphaVersionBanner` with `DevelopmentStageBanner` so
that a banner is always shown if the user uses a non-stable version of
Sharezone.
This is useful for #1290 (new "preview" stage for preview builds in
PRs).

Currently the banner is only shown in alpha, not in beta. This will show
a banner in alpha and beta.


![grafik](https://github.com/SharezoneApp/sharezone-app/assets/29028262/44bcbfa5-8137-4fe2-81f0-a0cc7db2e9d1)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a Development Stage Banner to inform users about the
current development stage of the app.
- **Refactor**
- Improved the flexibility of testing by allowing the development stage
variable to be overridden.
- Enhanced the Development Stage Banner to dynamically display the app's
development stage.
- **Tests**
- Added tests to ensure the Development Stage Banner accurately reflects
the app's current stage.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
nilsreichardt added a commit that referenced this pull request Feb 21, 2024
…flow (#1305)

#1290 added the `flutter pub global activate --source path
"$CI_CD_DART_SCRIPTS_PACKAGE_PATH"` command but without defining
`CI_CD_DART_SCRIPTS_PACKAGE_PATH`

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit


- **Chores**
	- Updated CI/CD workflow settings for enhanced operations.


<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants