-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sz build web
in web-app preview job and add preview
stage to it.
#1290
Conversation
Warning Rate Limit Exceeded@Jonas-Sander has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 26 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Visit the preview URL for this PR (updated for commit 0eb2c93): https://sharezone-test--pr1290-web-app-preview-stag-33swv0dk.web.app (expires Sat, 10 Feb 2024 14:41:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
sz build web
and use it in GitHub Actions.
sz build web
and use it in GitHub Actions.sz build web
in web-app preview job and add preview
stage to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This replaces the `AlphaVersionBanner` with `DevelopmentStageBanner` so that a banner is always shown if the user uses a non-stable version of Sharezone. This is useful for #1290 (new "preview" stage for preview builds in PRs). Currently the banner is only shown in alpha, not in beta. This will show a banner in alpha and beta. ![grafik](https://github.com/SharezoneApp/sharezone-app/assets/29028262/44bcbfa5-8137-4fe2-81f0-a0cc7db2e9d1) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a Development Stage Banner to inform users about the current development stage of the app. - **Refactor** - Improved the flexibility of testing by allowing the development stage variable to be overridden. - Enhanced the Development Stage Banner to dynamically display the app's development stage. - **Tests** - Added tests to ensure the Development Stage Banner accurately reflects the app's current stage. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…flow (#1305) #1290 added the `flutter pub global activate --source path "$CI_CD_DART_SCRIPTS_PACKAGE_PATH"` command but without defining `CI_CD_DART_SCRIPTS_PACKAGE_PATH` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated CI/CD workflow settings for enhanced operations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Use
sz build web
in web-app preview job and addpreview
stage to it.Together with #1291 this will display a "PREVIEW" banner for all previews.
Since this uses
pull_request_target
one can't see it in the preview here. I checked manually though (by overridingpull_request_target
withpull_request
)