Fix color of continue button in onboarding #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nilsreichardt
commented
Mar 9, 2024
nilsreichardt
commented
| Before | After |
|---|---|
 |
 |
github-actions
bot
added
the
feature: authentification
|
Visit the preview URL for this PR (updated for commit d31e4ed): https://sharezone-test--pr1385-fix-onboarding-name-gjk5mkjn.web.app (expires Tue, 12 Mar 2024 17:01:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Jonas-Sander
reviewed
Mar 9, 2024
| child: AnimatedSwitcher( | ||
| duration: const Duration(milliseconds: 250), | ||
| child: IconButton.filled( | ||
| key: ValueKey(onTap == null), |
There was a problem hiding this comment.
This is so that it rebuilds if onTap changes right?
There was a problem hiding this comment.
Yes, otherwise AnimatedSwitcher doesn't it needs to animate
Jonas-Sander
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.