Add adding grades to a term and enhance grade logic. #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jonas Sander <Jonas-Sander@users.noreply.github.com>
…he average grades of every subject
…term and subject grade'
Jonas-Sander
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the grade feature logic and adds a very hacky version of a functioning add grade dialog.
Currently only two grading systems are implemented: 1-6 (+-) and 0-15 points, both have predefined possible values.
In the future I'll need to make also non-discrete grading systems work (e.g. 1-6 with decimals).
In the add grade dialog only 1-6(+-) will work currently though, because the term is always created with this grade system via the UI.
Also adding real courses does not work yet, I'm just using a fake subject.
I wasn't sure what our exact plan was like again (courses with old courses? when does stuff update? how are the subjects connected to a course?) and also I thought its maybe better to do it in a future PR.
grades.webm