-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more grading systems #1441
Add more grading systems #1441
Conversation
… possible grades'
… $InvalidGradeValueException when added.'
…thInvalidValueIsAdded
This reverts commit 1932a70.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(I will at the code generation check now)
Visit the preview URL for this PR (updated for commit 5332c96): https://sharezone-console-dev--pr1441-other-grading-system-vx0qqjdb.web.app (expires Sat, 13 Apr 2024 15:04:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 471536afe3f6ec4895d9ea75513730b515d17eb6 |
Visit the preview URL for this PR (updated for commit 5332c96): https://sharezone-website-dev--pr1441-other-grading-system-83ob3tmw.web.app (expires Sat, 13 Apr 2024 15:05:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e |
Don't show the calculated average grade if the grading system is not numerical. To be able to do this I added `GradeResult.gradingSystem` and `GradeValue.gradingSystem`. Before: ![image](https://github.com/SharezoneApp/sharezone-app/assets/29028262/d0eae3a3-f5db-4c0c-ba6d-0d0a2032e36d) After: ![image](https://github.com/SharezoneApp/sharezone-app/assets/29028262/8ab3adf2-5d30-45e7-a54d-3711070c08a4) Requires #1441 --------- Co-authored-by: Jonas <--help>
Added grade systems:
Not yet added:
Bugs:
Before the code differentiated between grade systems where the user would choose between a list of values and where a grade numerical value would need be written.
Now there is not a clear cut differentiation anymore. E.g. 0 - 15 points was a list of possible values before, now it is a
ContinuousNumericalPossibleGradesResult
:The UI will need to decide what type of input it should show.
Values with special grade strings can be accessed by
ContinuousNumericalPossibleGradesResult.specialGrades
.There is another grade result for grade systems where the user would never see a number:
The numbers are for the internal calculations or we might decide to use it to show the user how close he is to one of the results.
Österreichische Verhaltensnoten
I just hardcoded the names as string for now. I'm not sure if an enum is better for the future?
-> I will decide this in another PR
Österreichiches Notensystem (1-5)
Wikipedia: Schulnote (Österreich)](https://de.wikipedia.org/wiki/Schulnote#%C3%96sterreich)
I just made it decimal and added no special grade strings (like e.g. "4-"). Should I add the special grade strings? I don't know what the exact value would be (e.g.: 4.25 vs 4.33).
-> For now we don't add specialGrade strings here.
Schweizer Notensystem (6-1)
Because so many different ways could be chosen, I just made it decimal and added no special grade strings (like e.g. "4+"). Should I add the special grade strings?
-> We decided on no for now
For now not relevant, as we decided on leaving out the grade performance for now.
This is a problem for future us that we will ignore for now.