Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete 'Add Grade Dialog' #1456

Merged
merged 36 commits into from
Apr 17, 2024
Merged

Complete 'Add Grade Dialog' #1456

merged 36 commits into from
Apr 17, 2024

Commits on Apr 15, 2024

  1. Remove required and optional fields

    @nilsreichardt
    nilsreichardt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    0678d9d View commit details
    Browse the repository at this point in the history

  2. Add UI strings and icons for PredefinedGradeTypes

    @nilsreichardt
    nilsreichardt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    247a5fd View commit details
    Browse the repository at this point in the history

  3. Add MaxWidthConstraintBox to the help dialog for the title

    @nilsreichardt
    nilsreichardt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    5293edf View commit details
    Browse the repository at this point in the history

  4. Add helper dialog for the date

    @nilsreichardt
    nilsreichardt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    2febebf View commit details
    Browse the repository at this point in the history

  5. Add validation for grade title

    @nilsreichardt
    nilsreichardt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    75d4dc3 View commit details
    Browse the repository at this point in the history

  6. Set title when changing grade type

    @nilsreichardt
    nilsreichardt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    26be36b View commit details
    Browse the repository at this point in the history

  7. Add note for creating a term when adding a grade

    @nilsreichardt
    nilsreichardt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    768e1d7 View commit details
    Browse the repository at this point in the history

  8. Add note about best grade

    @nilsreichardt
    nilsreichardt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    409b341 View commit details
    Browse the repository at this point in the history

  9. temp

    @nilsreichardt
    nilsreichardt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    3b4d7dc View commit details
    Browse the repository at this point in the history

  10. Select subject

    @nilsreichardt
    nilsreichardt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    c7f7770 View commit details
    Browse the repository at this point in the history

  11. Update _title

    @nilsreichardt
    nilsreichardt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d92ab29 View commit details
    Browse the repository at this point in the history

  12. Show distinct values

    @nilsreichardt
    nilsreichardt committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    68a8670 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Display error message when course is missing.

    @nilsreichardt
    nilsreichardt committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    86ba4cc View commit details
    Browse the repository at this point in the history

  2. Add error message for grade type missing

    @nilsreichardt
    nilsreichardt committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    28761b5 View commit details
    Browse the repository at this point in the history

  3. Add error message for grade value missing

    @nilsreichardt
    nilsreichardt committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a8784b5 View commit details
    Browse the repository at this point in the history

  4. Add error message for term not selected

    @nilsreichardt
    nilsreichardt committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c148b22 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into add-grade-logic

    @nilsreichardt
    nilsreichardt committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f7eedb9 View commit details
    Browse the repository at this point in the history

  6. Auto select the current term

    @nilsreichardt
    nilsreichardt committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    4625487 View commit details
    Browse the repository at this point in the history

  7. Use grading system from term and disable take into account switch whe… 

    …n grading system does not match
    @nilsreichardt
    nilsreichardt committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7e62abd View commit details
    Browse the repository at this point in the history

  8. Validate if grade is parsable

    @nilsreichardt
    nilsreichardt committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    53f3f99 View commit details
    Browse the repository at this point in the history

  9. Update term automatically

    @nilsreichardt
    nilsreichardt committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    3aafe86 View commit details
    Browse the repository at this point in the history

  10. Stream subjects

    @nilsreichardt
    nilsreichardt committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    8f00bb7 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Fix save grade

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    1950e68 View commit details
    Browse the repository at this point in the history

  2. Refactor UI exception part

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    52f1da5 View commit details
    Browse the repository at this point in the history

  3. Add crashlytics to controller

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4489dc7 View commit details
    Browse the repository at this point in the history

  4. Fix factroy

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9db58a1 View commit details
    Browse the repository at this point in the history

  5. Set grading system of term if grade is null

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c3ac99d View commit details
    Browse the repository at this point in the history

  6. Display invalid grade error message

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    dc6c455 View commit details
    Browse the repository at this point in the history

  7. Switch title is equal to previous gradeType

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    cca9d50 View commit details
    Browse the repository at this point in the history

  8. Make grade type non nullable

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    dc7ba4b View commit details
    Browse the repository at this point in the history

  9. Refactor

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    1853057 View commit details
    Browse the repository at this point in the history

  10. Reset grade error text

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    48635b3 View commit details
    Browse the repository at this point in the history

  11. Add license

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    74474fb View commit details
    Browse the repository at this point in the history

  12. Fix test

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2ed2e1c View commit details
    Browse the repository at this point in the history

  13. Update goldens

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    a6bb53b View commit details
    Browse the repository at this point in the history

  14. Reset grade after changing the grade system

    @nilsreichardt
    nilsreichardt committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    79eae41 View commit details
    Browse the repository at this point in the history