Add grading system to create term page #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nilsreichardt
commented
Apr 15, 2024
nilsreichardt
commented
github-actions
bot
added
the
feature: grades
nilsreichardt
commented
Apr 15, 2024
Comment on lines
+156
to
+168
| builder: (context) => SimpleDialog( | ||
| title: const Text("Notensystem auswählen"), | ||
| children: [ | ||
| for (final gradingSystem in GradingSystem.values) | ||
| ListTile( | ||
| title: Text(gradingSystem.displayName), | ||
| onTap: () { | ||
| Navigator.of(context).pop<GradingSystem?>(gradingSystem); | ||
| }, | ||
| ), | ||
| ], | ||
| ), | ||
| ); |
There was a problem hiding this comment.
Later, this dialog will be replaced with a shared one which is also used on grades dialog page (see #1456).
|
Visit the preview URL for this PR (updated for commit 5055966): https://sharezone-test--pr1457-grading-system-to-te-1n1ww4dp.web.app (expires Thu, 18 Apr 2024 15:48:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Jonas-Sander
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.