Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grades and plus page as notification navigation targets. #1483

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Apr 21, 2024

(I didn't try it out, since I can't set the action type with the Firebase UI it seems like)

@github-actions github-actions bot added feature: notifications Push-Notifications and In-App-Notifications. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription labels Apr 21, 2024
Copy link

github-actions bot commented Apr 21, 2024

Visit the preview URL for this PR (updated for commit af46722):

https://sharezone-test--pr1483-add-notification-nav-g9m7ipab.web.app

(expires Wed, 24 Apr 2024 16:54:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander Jonas-Sander marked this pull request as ready for review April 21, 2024 16:50
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Apr 21, 2024
Merged via the queue into main with commit 8d4740d Apr 21, 2024
63 checks passed
@Jonas-Sander Jonas-Sander deleted the add-notification-nav-targets branch April 21, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: notifications Push-Notifications and In-App-Notifications. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants