Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Id.id to Id.value. #1550

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Change Id.id to Id.value. #1550

merged 3 commits into from
Apr 24, 2024

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Apr 24, 2024 •
edited
Loading

No description provided.

@github-actions github-actions bot added feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: information sheet Information sheets are posted to courses as a way to announce information. feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups Groups umbrella term for courses and classes. testing user: teacher feature: feedback Users can send us feedback to improve the app. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: grades Users can add their grades to Sharezone. labels Apr 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit e4063a6):

https://sharezone-console-dev--pr1550-change-id-val-9ws8y2cl.web.app

(expires Sat, 27 Apr 2024 12:28:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 471536afe3f6ec4895d9ea75513730b515d17eb6

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit e4063a6):

https://sharezone-website-dev--pr1550-change-id-val-n1ed0018.web.app

(expires Sat, 27 Apr 2024 12:28:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 372b0431a96247f908d9a97d5d865de1c8b3b04e

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit e4063a6):

https://sharezone-test--pr1550-change-id-val-ukdd1tr0.web.app

(expires Sat, 27 Apr 2024 12:29:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

nilsreichardt
nilsreichardt approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit 99c7e29 Apr 24, 2024
37 checks passed
@Jonas-Sander Jonas-Sander deleted the change-id-val branch April 24, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
feature: feedback Users can send us feedback to improve the app. feature: grades Users can add their grades to Sharezone. feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. feature: information sheet Information sheets are posted to courses as a way to announce information. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). testing user: teacher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonas-Sander @nilsreichardt