Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lessons row top padding on dashboard page #1630

Merged
merged 1 commit into from
May 10, 2024
Merged

Remove lessons row top padding on dashboard page #1630

merged 1 commit into from
May 10, 2024

Conversation

nilsreichardt
Copy link
Member

Before After
Screenshot_1715233437 Screenshot_1715233424

Used Google Pixel 4

@github-actions github-actions bot added feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.). labels May 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Visit the preview URL for this PR (updated for commit de95fae):

https://sharezone-test--pr1630-remove-top-padding-l-pc2oju1d.web.app

(expires Sun, 12 May 2024 18:50:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt mentioned this pull request May 9, 2024
Merged
@nilsreichardt nilsreichardt added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 9f4250d May 10, 2024
36 checks passed
@nilsreichardt nilsreichardt deleted the remove-top-padding-lessons-low branch May 10, 2024 17:10
nilsreichardt added a commit that referenced this pull request May 11, 2024
@nilsreichardt
Fix dashboard homework card (#1631)
34c9cfa 
| Before | After |
|--------|--------|
|
![Screenshot_20240509_080924](https://github.com/SharezoneApp/sharezone-app/assets/24459435/e021c082-af65-4975-8ce1-113e55859528)
|
![Pixel9C-Dashboard](https://github.com/SharezoneApp/sharezone-app/assets/24459435/ddcc65ff-d2f8-4c7c-a20d-6d818f61f02a)
|

Requires #1630
Fixes #1560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsreichardt @Jonas-Sander