-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharezone Wrapped #1660
Sharezone Wrapped #1660
Conversation
Visit the preview URL for this PR (updated for commit 6bf5919): https://sharezone-test--pr1660-sharezone-rewrapped-94q7hx7k.web.app (expires Sat, 29 Jun 2024 21:04:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
⬇️ Builds generated by Codemagic for commit 6bf5919 ⬇️ Note: Only Sharezone team members are able to install the iOS app.
(expires Fri, 26 Jul 2024 21:13:03 GMT) |
Just some notes before reviewing it fully: If e.g. "Prüfungen" is 0 there is still the "1.", "2.", "3." subject list which doesn't really makes sense I fear that if not all exams are added to Sharezone and the number of it is really off, then people might have some slight bias against posting a screenshot as to not have questions about the wrong number of exams. Thats of course just my imagination, might be completely different in reality. I'm also not sure what would be the best way to fix that. Maybe being able to hide the stat? But might be too much hassle for this first MVP version of wrapped or it might be non-obvious too the user. Or the problem doesn't really exist, idk... 🤷♂️ Ideally I would like a small hint that explains that the hours of lessons is based on the current lesson plan, we can skip that though. Also not sure if it would look good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good job! LGTM
This reverts commit 69d3e50.
Description
This PR adds the Sharezone Wrapped feature. It is a test for this year if users want this feature and if it's worth maintaining. Therefore, the code is not the best.
Users can access the page via the settings. The tile on the settings page is behind a feature flag. Therefore, we can disable this tile when the last state has started with the new school year.
Also, users will get a tip card on the dashboard page to view the wrapped.
Demo
RPReplay_Final1719138310.1.mp4
Note: I renamed it from Rewrapped to Wrapped because I noticed Spotify calls it Wrapped: https://pr-newsroom-wp.appspot.com/2023-wrapped/
Closes #1605