Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider holidays for next schoolday #1678

Merged
merged 8 commits into from
Jul 3, 2024
Merged

Consider holidays for next schoolday #1678

merged 8 commits into from
Jul 3, 2024

Conversation

ImGxrke
Copy link
Contributor

@ImGxrke ImGxrke commented Jun 28, 2024

Fixes #1179

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2024

CLA assistant check
All committers have signed the CLA.

@Jonas-Sander Jonas-Sander added the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Jun 30, 2024
@github-actions github-actions bot removed the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Jun 30, 2024
Copy link

github-actions bot commented Jun 30, 2024

Visit the preview URL for this PR (updated for commit c1ae101):

https://sharezone-test--pr1678-consider-holidays-fo-yx7c773n.web.app

(expires Fri, 05 Jul 2024 11:14:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander
Copy link
Collaborator

Hey, thanks! :) My development environment is currently kinda broken, I'll try to review it in the next few days.

Several tests are currently failing with the following error: Exception: A BlocProvider ancestor with Type BlocProvider<HolidayBloc> should be given in the widget tree. This means that in the setup code for the widget tests you'll need to add a BlocProvider<HolidayBloc> to the widget tree in the test file homework_dialog_test.dart line 281.
There are other failing unit tests as well though.

@ImGxrke
Copy link
Contributor Author

ImGxrke commented Jun 30, 2024

The test are now fixed, however I am not sure if the implementation of the BlocProvider<HolidayBloc> is done in the right way.

@Jonas-Sander Jonas-Sander added the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Jul 2, 2024
@github-actions github-actions bot removed the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Jul 2, 2024
@Jonas-Sander Jonas-Sander added the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Jul 2, 2024
@github-actions github-actions bot removed safe to test Used for fork PRs when the code is safe to test to trigger our CI. labels Jul 2, 2024
@Jonas-Sander Jonas-Sander added the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Jul 2, 2024
@github-actions github-actions bot removed the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Jul 2, 2024
Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job :)

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Jul 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 2, 2024
@Jonas-Sander Jonas-Sander added this pull request to the merge queue Jul 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 2, 2024
@Jonas-Sander Jonas-Sander added this pull request to the merge queue Jul 3, 2024
Merged via the queue into SharezoneApp:main with commit 9dd1f42 Jul 3, 2024
43 of 52 checks passed
@ImGxrke ImGxrke deleted the consider-holidays-for-next-schoolday branch July 3, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Nächster Schultag" due date selection chip doesn't take holidays into account.
3 participants