Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show material dialog for deleting the account on macos due to a Flutter bug #1730

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

nilsreichardt
Copy link
Member

Because of flutter/flutter#154793 onPressed of CupertinoActionSheetAction isn't called. Therefore, the Cupertino dialog shouldn't be shown when the user uses macOS.

Copy link

github-actions bot commented Sep 8, 2024

Visit the preview URL for this PR (updated for commit dd94808):

https://sharezone-test--pr1730-show-material-dialog-8rmrgomf.web.app

(expires Wed, 11 Sep 2024 17:05:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 8, 2024
Merged via the queue into main with commit e6920c7 Sep 8, 2024
36 checks passed
@nilsreichardt nilsreichardt deleted the show-material-dialog-on-macos branch September 8, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants