-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved title for calendar export on timetable settings page #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvilMonkey09
requested review from
Jonas-Sander and
nilsreichardt
as code owners
October 16, 2024 10:11
github-actions
bot
added
the
feature: timetable / calendar
Includes anything regarding lessons (timetable) and events (calendar).
label
Oct 16, 2024
app/lib/settings/src/subpages/timetable/timetable_settings_page.dart
Outdated
Show resolved
Hide resolved
…e.dart Co-authored-by: Nils Reichardt <me@nils.re>
nilsreichardt
added
the
safe to test
Used for fork PRs when the code is safe to test to trigger our CI.
label
Oct 16, 2024
github-actions
bot
removed
safe to test
Used for fork PRs when the code is safe to test to trigger our CI.
labels
Oct 16, 2024
Visit the preview URL for this PR (updated for commit 5df1cdf): https://sharezone-test--pr1769-improve-title-6gunewus.web.app (expires Sat, 19 Oct 2024 19:59:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
nilsreichardt
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nilsreichardt
added
the
safe to test
Used for fork PRs when the code is safe to test to trigger our CI.
label
Oct 16, 2024
github-actions
bot
removed
the
safe to test
Used for fork PRs when the code is safe to test to trigger our CI.
label
Oct 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 16, 2024
nilsreichardt
changed the title
Improved title for timetable settings (calendar-export)
Improved title for calendar export on timetable settings page
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature: timetable / calendar
Includes anything regarding lessons (timetable) and events (calendar).
testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.