Add placeholder for ads #1771
Merged
Add placeholder for ads #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
w: dashboard-page
|
Visit the preview URL for this PR (updated for commit 32d020f): https://sharezone-test--pr1771-placeholder-ads-neje41ns.web.app (expires Sat, 19 Oct 2024 21:00:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Jonas-Sander
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a placeholder when the ads are loading. However, for the homework and timetable page, we don't know the height at the beginning. This depends on the device height. In the future, we could also cache this information (I already created a ticket: #1772).
Demo
iPhone
Screen.Recording.2024-10-16.at.22.49.19.mov
iPad Pro 13"
Screen.Recording.2024-10-16.at.22.48.26.mov
iPhone SE
Screen.Recording.2024-10-16.at.22.55.56.mov