Moves the Rubik font into a separate package #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
dependencies
|
Visit the preview URL for this PR (updated for commit b8672fc): https://sharezone-test--pr902-move-sharezone-font-pz2wsuiw.web.app (expires Sat, 09 Sep 2023 23:11:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
|
Blocked by: eBay/flutter_glove_box#158 |
|
Closing it for now. When eBay/flutter_glove_box#158 is resolved, we can reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving our Sharezone font into a separate package allows adding the package easily to another package, like the
sharezone_widgetspackage. This required when writing golden test in a different package, likesharezone_widget, package thegolden_toolkitpackage loads the fonts from thepubspec.yaml.