This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
Usable changes from #21 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there may be a solution but for now this commit is just for preserving these changes
SailReal
reviewed
Jul 8, 2018
| const int work_area_width, | ||
| const std::wstring &desktop_name) | ||
| : full_work_area(work_area_width) | ||
| { | ||
| old_desktop = ::GetThreadDesktop(GetCurrentThreadId()); | ||
|
|
||
|
|
There was a problem hiding this comment.
Was the new line intentional?
|
|
||
| // EXPLICIT_ACCESS with second ACE for admin group | ||
| explicit_access_admin.grfAccessPermissions = GENERIC_ALL; | ||
| explicit_access_admin.grfAccessMode = SET_ACCESS; //DENY_ACCES |
There was a problem hiding this comment.
SET_ACCESS means DENY_ACCESS or should it be DENY_ACCESS and with that it isn't working?
There was a problem hiding this comment.
this line was like this from the beginning, it does get changed with #13
| const char ADDITIONAL_APPLICATION_PATH_PROPERTY[] = "additional_application_path"; | ||
| const char CLOSING_POLICY_PROPERTY[] = "restrict_closing"; | ||
|
|
||
| void TrimMessage(std::wstring &msg) |
There was a problem hiding this comment.
Why are TrimMessage and BeginsWith not in the namespace of SharedFunctions?
There was a problem hiding this comment.
because they are not used anywhere but in this file
SailReal
approved these changes
Jul 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the good (read: usable) stuff from #21 - just some minor refactoring and simplification (don't be alarmed by the amount of changed files, it is just
asioagain because I renamed the network project)@bencikpeter I added your token lib to the
SharedFunctionalityproject and had to edit thetokenLib.cppfile to get it compile clean:char *Wtsapi32.libNot sure why it is not compiling on AppVeyor yet, will have a look tomorrow...