-
Notifications
You must be signed in to change notification settings - Fork 3
Check access rights of config files before opening them #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thx for the awesome work...a few points to discuss:
- Maybe we can introduce an Refresh button in the Cage Chooser which will do the same as the 'F5' keystroke?
- Maybe we can set the current size as the max size of the Configurator otherwise is it much to do to make it more responsive?
- Maybe we can display a simple text in the Configurator, that the saving was successfully?
Oh and we have a conflict file "SharkCage/CageChooser/CageChooserForm.cs" |
|
change order in CageManager for faster message processing on startup enter button in CageChooser now does the same as pressing the start button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice work!
@DonatJR Sorry for a late reply, I somehow overlooked that mention I had a look at
so I´d assume it´s a better idea to use those?
|
minor improvements from general discussion and #85
fixes #75
Configurator
andService
now check the access rights of the config file before opening / processing them furtherChooser
is now based on registry entries written by theConfigurator
@bencikpeter Could you take a look at the
CheckConfigAccessRights
function in theCageService
? You have the most experience with the Windows API in this regardhttps://github.com/SharkCagey/HTWG_shark_cage/pull/85/files#diff-c70ab997f5ee033d6f6d8bd7ca7264b8R243