Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyAnimeList api sometimes returns without genres field #42

Closed
Sharkaboi opened this issue Aug 29, 2021 · 0 comments · Fixed by #44
Closed

MyAnimeList api sometimes returns without genres field #42

Sharkaboi opened this issue Aug 29, 2021 · 0 comments · Fixed by #44
Assignees
Labels
bug Something isn't working

Comments

@Sharkaboi
Copy link
Owner

Sharkaboi commented Aug 29, 2021

Make genres field optional

@Sharkaboi Sharkaboi changed the title MyAnime MyAnimeList api sometimes returns without genres field Aug 29, 2021
@Sharkaboi Sharkaboi self-assigned this Aug 29, 2021
@Sharkaboi Sharkaboi added the bug Something isn't working label Aug 29, 2021
Sharkaboi added a commit that referenced this issue Dec 23, 2021
@Sharkaboi Sharkaboi mentioned this issue Jun 11, 2022
Merged
6 tasks
Sharkaboi added a commit that referenced this issue Jun 11, 2022
* Updated readme assets.

* Bump versions

* Set compiler args to allow experimental time apis

* Refactor packages

* Refactor packages (2)

* Refactor packages (3)

* Fix moshi and agp incompatibility issue

* Fix light status bar on auth activity

* Code Refactoring (4)

* Fixes #42

* Invalid query for whitespace appended <3 length string

* Fixes #41

* Fixes #35

* Refactor function signature

* Move string parse logic to enum as static function

* Move parsing logic of args to AnimeSeasonWrapper

* Move to new days and hours extension

* Refactor to savedStateHandle to handle FragmentStateManager recreating view causing reload (1)

* Refactor to new anime status parse function signature

* Fixes #38

* Code refactoring

* Refactor to savedStateHandle to handle FragmentStateManager recreating view causing reload (2)

* Refactor to seconds and hours datetime extensions

* Refactor to savedStateHandle to handle FragmentStateManager recreating view causing reload (3)

* Moved to lastOrNull for paged flow collection

* Revert lastOrNull

* Refactor to savedStateHandle to handle FragmentStateManager recreating view causing reload (4)

* Refactor to savedStateHandle to handle FragmentStateManager recreating view causing reload (5)

* Refactored to use AnimeAndMangaGridSpanCount

* Refactor to savedStateHandle to handle FragmentStateManager recreating view causing reload (6)

* Refactor to savedStateHandle to handle FragmentStateManager recreating view causing reload (7)

* Fixed LoadStateListener not being cleaned up

* Refactor to savedStateHandle to handle FragmentStateManager recreating view causing reload (8)

* Code refactoring

* Refactor to savedStateHandle to handle FragmentStateManager recreating view causing reload (9)

* Code refactoring

* Refactor to savedStateHandle to handle FragmentStateManager recreating view causing reload (10)

* Code refactoring

* Refactor to savedStateHandle to handle FragmentStateManager recreating view causing reload (11)

* Refactor to savedStateHandle to handle FragmentStateManager recreating view causing reload (12)

* Closes #31

* Code refactoring

* Bump version name

* Fix invalid import for getLocalDateFromDayAndTime in UtilsTest

* Migrate to Robolectric for local unit testing instead of instrumentation tests.

* Make empty layout of search pages responsive

* Set fab size for search fab to maintain uniformity

* Add robolectric to readme

* Add support for landscape orientation

* Add support for landscape orientation (2)

* Code Refactoring (1)

* Code Refactoring, Refactor packages, Add missing imports.

* Make app work in split screen

* Up deps

* Fix coil function signature changing

* Set search fields to single line

* Fix di

* Remove acra

* Migrate to Apollo 3

* Add graphql query alias to prevent name shadowing

* Move to target and compile sdk 32

* Up dependencies

* Add share button to both anime and mana details page

* Alphabetically order version variables

* Set apollo generated package to com.sharkaboi.mediahub

* Disable final-newline ktlint rule

* lint format

* Make bottom navigation not auto hide, move search fabs to individual fragments, make root as ConstraintLayout

* Make grid span be considered from constants.xml

* Remove unwanted margin

* Code refactoring

* Revert versions to same as master

* Send empty paging data if null from paging source

* Up kotlin version to 1.7.0

* Make actions only run on pull requests and push to main/master

* Remove room deps

* Code refactoring

* Code refactoring anime_details

* Code refactoring manga_details

* Move to getCatchingPaging

* Move to getCatching

* Code refactoring

* ktlint format

* Fix capitalizeFirst

* Fix capitalizeFirst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant