Bugfix: Newly downloaded workfile #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tilix4
requested changes
Mar 12, 2024
|
|
||
| # Set last publish time to current time | ||
| # This script assumes it is only executed in a known up to date workfile | ||
| # TODO Use UTC time instead of local time |
There was a problem hiding this comment.
As we discussed, switching UTC should be a separate PR, which is already available here (PR 12).
There was a problem hiding this comment.
Ok, therefore this is not a TODO any more, you can remove this line.
openpype/hosts/blender/utility_scripts/set_workfile_publish_time.py
Outdated
Show resolved
Hide resolved
Add app group to set workfile publish time prelaunch hook Co-authored-by: Félix David <felixg.david@gmail.com>
Tilix4
reviewed
Mar 12, 2024
openpype/hosts/blender/hooks/pre_set_current_time_to_workfile.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Félix David <felixg.david@gmail.com>
Tilix4
approved these changes
Mar 13, 2024
Sharkitty
merged commit 723de90
into
feature/blender_workfile_out_of_date_handling
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fix newly downloaded workfile (via
pre_copy_last_published_workfilehook) wrongly marked as out of date.Testing notes:
_oldtechnique or locally unavailable workfile).