Validators not applied to parameters with BindingSource = Form

[steverb38]

Hi,

Thanks for providing this package for auto FluentValidation!

My first attempt as using this was trying to apply a Validator to a Form parameter but I see the code specifically only applies validators to Body or Query parameters. Not being a web developer particularly, is there a specific reason for this restriction?

More a question in education (for me) perhaps?

Steve.

[mvdgun]

Hi @steverb38,

I don't think there is a specific reason for not having validation on [FromForm] parameters other than that I never needed it in my personal projects (from which this library sprouted). I'm currently thinking about introducing configuration options for the BindingSources. Could you provide me with some examples where you would need validation on [FromForm] parameters?

[steverb38]

Hi,

My use-case was submitting a form for a file upload to the server, along with some associated parameters to control the behaviour of the API in processing the uploaded file. The API action method looks something like:

[HttpPost]
public async Task<ActionResult<MyResponse>> Post([FromForm] MyRequest request)
{
...
}

where MyRequest is like:

public class MyRequest
{
    public IFormFile File { get; set; }

    public string Param1 { get; set; }

    public bool Param2 { get; set; }

    ....
}

There were then some validations to perform on the Param1, Param2,... values to ensure together they made sense.

Steve.

[steverb38]

OK - I updated a local copy of FluentValidationAutoValidationActionFilter.cs on line 55 to allow a BindingSource of Form as well as Body and Query.

That seemed to then work OK in my test scenario. No other testing done though!

[mvdgun]

@steverb38 that's great to hear! I actually have been playing with the idea to expose the binding sources via the options builder and via the data annotations attributes to make it all configurable. The default would be BindingSource.Body, BindingSource.Body and BindingSource.Query. The only issue I see with the defaults is if I should consider this a breaking change.

[mvdgun]

Opened a PR for it: https://github.com/SharpGrip/FluentValidation.AutoValidation/pull/8/files. Would appreciate it if you could take a look at it :).

[steverb38]

Hi. Fantastic! I'll take a look later today. 👍

[mvdgun]

Hi @steverb38, I just released v1.2.0 which includes the configurable binding sources.