Only run strict lint check on stable Rust #203
SharparamAnnotations
3 errors and 10 warnings
|
field `mod_info_path` is never read:
crates/cli/src/project.rs#L26
error: field `mod_info_path` is never read
--> crates/cli/src/project.rs:26:9
|
14 | pub struct Project {
| ------- field in this struct
...
26 | pub mod_info_path: PathBuf,
| ^^^^^^^^^^^^^
|
= note: `Project` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
|
|
match can be simplified with `.unwrap_or_default()`:
crates/cli/src/lib.rs#L56
error: match can be simplified with `.unwrap_or_default()`
--> crates/cli/src/lib.rs:56:55
|
56 | let level_filter = level_filter.unwrap_or_else(|| match config.log_level_filter {
| _______________________________________________________^
57 | | Some(f) => f,
58 | | None => Default::default(),
59 | | });
| |_____^ help: replace it with: `config.log_level_filter.unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default
= note: `-D clippy::manual-unwrap-or-default` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::manual_unwrap_or_default)]`
|
|
clippy_check (stable)
Clippy has exited with exit code 101
|
|
the following explicit lifetimes could be elided: 'de:
crates/lib/src/serde.rs#L22
warning: the following explicit lifetimes could be elided: 'de
--> crates/lib/src/serde.rs:22:14
|
22 | impl<'de> Visitor<'de> for VersionVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
22 - impl<'de> Visitor<'de> for VersionVisitor {
22 + impl Visitor<'_> for VersionVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
crates/lib/src/serde.rs#L63
warning: the following explicit lifetimes could be elided: 'de
--> crates/lib/src/serde.rs:63:14
|
63 | impl<'de> Visitor<'de> for FactorioVersionVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
63 - impl<'de> Visitor<'de> for FactorioVersionVisitor {
63 + impl Visitor<'_> for FactorioVersionVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
crates/lib/src/serde.rs#L106
warning: the following explicit lifetimes could be elided: 'de
--> crates/lib/src/serde.rs:106:14
|
106 | impl<'de> Visitor<'de> for DependencyVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
106 - impl<'de> Visitor<'de> for DependencyVisitor {
106 + impl Visitor<'_> for DependencyVisitor {
|
|
|
field `mod_info_path` is never read:
crates/cli/src/project.rs#L26
warning: field `mod_info_path` is never read
--> crates/cli/src/project.rs:26:9
|
14 | pub struct Project {
| ------- field in this struct
...
26 | pub mod_info_path: PathBuf,
| ^^^^^^^^^^^^^
|
= note: `Project` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
match can be simplified with `.unwrap_or_default()`:
crates/cli/src/lib.rs#L56
warning: match can be simplified with `.unwrap_or_default()`
--> crates/cli/src/lib.rs:56:55
|
56 | let level_filter = level_filter.unwrap_or_else(|| match config.log_level_filter {
| _______________________________________________________^
57 | | Some(f) => f,
58 | | None => Default::default(),
59 | | });
| |_____^ help: replace it with: `config.log_level_filter.unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default
= note: `#[warn(clippy::manual_unwrap_or_default)]` on by default
|
|
the following explicit lifetimes could be elided: 'de:
crates/lib/src/serde.rs#L22
warning: the following explicit lifetimes could be elided: 'de
--> crates/lib/src/serde.rs:22:14
|
22 | impl<'de> Visitor<'de> for VersionVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
22 - impl<'de> Visitor<'de> for VersionVisitor {
22 + impl Visitor<'_> for VersionVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
crates/lib/src/serde.rs#L63
warning: the following explicit lifetimes could be elided: 'de
--> crates/lib/src/serde.rs:63:14
|
63 | impl<'de> Visitor<'de> for FactorioVersionVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
63 - impl<'de> Visitor<'de> for FactorioVersionVisitor {
63 + impl Visitor<'_> for FactorioVersionVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
crates/lib/src/serde.rs#L106
warning: the following explicit lifetimes could be elided: 'de
--> crates/lib/src/serde.rs:106:14
|
106 | impl<'de> Visitor<'de> for DependencyVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
106 - impl<'de> Visitor<'de> for DependencyVisitor {
106 + impl Visitor<'_> for DependencyVisitor {
|
|
|
field `mod_info_path` is never read:
crates/cli/src/project.rs#L26
warning: field `mod_info_path` is never read
--> crates/cli/src/project.rs:26:9
|
14 | pub struct Project {
| ------- field in this struct
...
26 | pub mod_info_path: PathBuf,
| ^^^^^^^^^^^^^
|
= note: `Project` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
match can be simplified with `.unwrap_or_default()`:
crates/cli/src/lib.rs#L56
warning: match can be simplified with `.unwrap_or_default()`
--> crates/cli/src/lib.rs:56:55
|
56 | let level_filter = level_filter.unwrap_or_else(|| match config.log_level_filter {
| _______________________________________________________^
57 | | Some(f) => f,
58 | | None => Default::default(),
59 | | });
| |_____^ help: replace it with: `config.log_level_filter.unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default
= note: `#[warn(clippy::manual_unwrap_or_default)]` on by default
|