Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge #18

Merged
merged 12 commits into from
Feb 17, 2020
Merged

merge #18

merged 12 commits into from
Feb 17, 2020

Conversation

ShawnYun
Copy link
Owner

No description provided.

erikzhang and others added 12 commits December 30, 2019 12:20
* add relay-block-filter

* modify

* modify

* modify

* modify

Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
* Adding some comments to datacache

* Adding Exception comment tip of @Tommo-L

Co-authored-by: Shargon <shargon@gmail.com>
…1389)

* update

* change fifoset to hashsetcache for knownhashes and senthashes

* format

* optimise HashSetCache

* remove FIFOSet

* remove FIFOSet and update ut

* change List to LinkedList

* remove bucket count upper limit

* update exception message

* Adding some comments

* dotnet format

* rename maxBucketCount

* format

* Cache count

* Vitor suggestions

* Update HashSetCache.cs

* format

* Fix

* fix counting count

* optimise

* optimse

* update List

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
…ived (#1408)

* add containsTx recheck

* add UT

* Update to just View check

* update

* revert

* Update UT_Blockchain.cs

Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
* inputs validation

* more validation

* recover constructor in ECPoint

* format

* minor changes

* format

* changes based on review

* recover validation in AesEncrypt
…60 (#1387)

* Fix undefined layout behaviour, and remove pinning

* Update UInt256.cs

* Update UInt256.cs

* add StructLayout

* set pack=1

* Explicit

* Remove UIntBase

* Revert constructor

* add unsafe

* Comment

* Comment Uint256

* Removing comments from value 1

* Removing comments from value1

Co-authored-by: Luchuan <luchuan@ngd.neo.org>
Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Shargon <shargon@gmail.com>
* Verify Import

* Default true
Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
@ShawnYun ShawnYun merged commit 45e6858 into ShawnYun:master Feb 17, 2020
@github-actions
Copy link

Pull Request Test Coverage Report for Build 7575b98f343873a0be998aabb4dfc640a67d8469-PR-18

  • 239 of 307 (77.85%) changed or added relevant lines in 37 files are covered.
  • 208 unchanged lines in 57 files lost coverage.
  • Overall coverage decreased (-1.9%) to 76.161%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/neo/Cryptography/Base58.cs 0 1 0.0%
src/neo/Cryptography/ECC/ECFieldElement.cs 3 4 75.0%
src/neo/Persistence/ReadOnlyView.cs 0 1 0.0%
src/neo/SmartContract/InteropService.Binary.cs 1 2 50.0%
src/neo/SmartContract/InteropService.Storage.cs 9 13 69.23%
src/neo/Ledger/Blockchain.cs 2 7 28.57%
src/neo/SmartContract/BinarySerializer.cs 18 23 78.26%
src/neo/Network/P2P/LocalNode.cs 5 12 41.67%
src/neo/IO/Helper.cs 0 8 0.0%
src/neo/IO/Caching/HashSetCache.cs 58 67 86.57%
Files with Coverage Reduction New Missed Lines %
src/neo/Consensus/ConsensusMessage.cs 1 78.57%
src/neo/Consensus/RecoveryMessage.cs 1 51.81%
src/neo/Cryptography/SCrypt.cs 1 79.5%
src/neo/IO/SerializableWrapper.cs 1 57.78%
src/neo/Network/P2P/Payloads/BlockBase.cs 1 66.67%
src/neo/Network/P2P/Payloads/Block.cs 1 82.58%
src/neo/Network/P2P/Payloads/ConsensusPayload.cs 1 84.09%
src/neo/Network/P2P/Payloads/Header.cs 1 46.67%
src/neo/Persistence/MemoryStore.cs 1 74.07%
src/neo/Persistence/StoreView.cs 1 89.8%
Totals Coverage Status
Change from base Build 05440f9b3a934228a0e8bbf6e2e6b595c29a9d79: -1.9%
Covered Lines: 9807
Relevant Lines: 12377

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants