Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure V4 API, reduce warnings #349

Merged
merged 16 commits into from
Sep 12, 2023
Merged

Conversation

nzdev
Copy link
Contributor

@nzdev nzdev commented Aug 25, 2023

Builds on #345.
Updates the shipped API files to include nullable annotations
Adds the new V4 APIs to the unshipped API files (When V4 is released, move entries to shipped API files)
Fix, Configure, Suppress code warnings.

@nzdev nzdev changed the title Track V4 API, reduce warnings Ensure V4 API, reduce warnings Aug 25, 2023
Copy link
Owner

@Shazwazza Shazwazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot to review! Would be good to have @nikcio have a peek as well in case I've missed anything. Have left a few comments/questions.

src/Examine.Lucene/ExamineTaxonomyReplicator.cs Outdated Show resolved Hide resolved
src/Examine.Lucene/Providers/LuceneSearcher.cs Outdated Show resolved Hide resolved
src/Examine.Lucene/Providers/LuceneSearcher.cs Outdated Show resolved Hide resolved
src/Examine.Lucene/Providers/LuceneIndex.cs Outdated Show resolved Hide resolved
@Shazwazza
Copy link
Owner

Thanks for the effort everyone, I'll trust our previous reviews are good and will merge.

@Shazwazza Shazwazza merged commit f2dc6e7 into Shazwazza:release/4.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants