Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

save_models fix for #125 (#127) #140

Merged
merged 1 commit into from
Dec 24, 2017
Merged

save_models fix for #125 (#127) #140

merged 1 commit into from
Dec 24, 2017

Conversation

apaleyes
Copy link
Collaborator

  • Updated GPModel to save full parameter name list, added simple save tests, and initialised self.model_parameters_iterations in init

* Updated GPModel to save full parameter name list, added simple save tests, and initialised self.model_parameters_iterations in __init__
@codecov-io
Copy link

codecov-io commented Dec 24, 2017

Codecov Report

Merging #140 into master will increase coverage by 0.63%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   76.11%   76.75%   +0.63%     
==========================================
  Files          91       92       +1     
  Lines        4112     4160      +48     
==========================================
+ Hits         3130     3193      +63     
+ Misses        982      967      -15
Impacted Files Coverage Δ
GPyOpt/core/bo.py 57.97% <100%> (+4.53%) ⬆️
GPyOpt/testing/core_tests/test_save.py 100% <100%> (ø)
GPyOpt/models/gpmodel.py 48.44% <100%> (+1.86%) ⬆️
GPyOpt/methods/bayesian_optimization.py 88.63% <0%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9e2bc...db3407a. Read the comment docs.

@apaleyes apaleyes merged commit 0eddb87 into master Dec 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants