Pass constraints to anchor point generator #150
Conversation
Currently the constraints are not being respected in the anchor point generator. This could lead to infeasible points being selected as anchor points. To fix this simply pass the commits to the design space object that is used for creating the anchor points.
|
Thanks for the PR! this is certainly a good catch!!! However, some of the tests are not passing yet. Could you please investigate that before we can merge? It would be great to add this to the library. |
The update to the design space in the anchor point generator resulted in infeasible points being discovered when generating the initial samples. This lead to diverging code path. Updating the expected test output to reflect this.
|
Hi, I checked that the results are feasible and everything is looking good at this end. Furthermore, I checked where the two code paths diverge. The only part of the code where the modified space is being used is the call to initial_design and subsequently RandomDesign. There, a few infeasible points are being generated by the call to get_samples_without_constraints. In the patched version of the code, get_samples_with_constraints catches this and generates replacements. Naturally, this leads to different initial designs and a different random generator state down the road. To sum up, it is probably best to replace the test case with the new output. I added a commit to do just that. |
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 76.74% 76.75% +<.01%
==========================================
Files 92 92
Lines 4162 4168 +6
==========================================
+ Hits 3194 3199 +5
- Misses 968 969 +1
Continue to review full report at Codecov.
|
LEleonora
force-pushed
the
feasible_anchor_points
branch
from
3e6131f to
50e93fd
Compare
|
That looks good, let's merge. |
Currently the constraints are not being respected in the anchor point
generator. This could lead to infeasible points being selected as
anchor points. To fix this simply pass the commits to the design space
object that is used for creating the anchor points.