Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade remix to 2xx #406

Merged
merged 9 commits into from
Oct 4, 2023
Merged

chore: upgrade remix to 2xx #406

merged 9 commits into from
Oct 4, 2023

Conversation

DonKoko
Copy link
Contributor

@DonKoko DonKoko commented Sep 29, 2023

Upgrading to remix v2.
This comes with some small changes:

  • Upgrading to TS 5.x. This means that typescript is more strict so it actually helped us solve a lot of issues that were unknown for us.
  • Upgrading remix-utils to @next which is a pre-release. Issue with that is that there are some broken dependencies so we need to npm i with legacy peer dependencies. Hopefully that gets fixed soon but we need to keep an eye.

@DonKoko DonKoko linked an issue Sep 29, 2023 that may be closed by this pull request
@DonKoko
Copy link
Contributor Author

DonKoko commented Sep 29, 2023

I unfortunately cannot merge this because of the issues with remix-utils with remix v2.
The issue is that tests wont run because with the way remix-utils currently works we need to install with --legacy-peer-deps.
sergiodxa/remix-utils#228

@mahendraHegde do you maybe have some ideas how we can go around this?

EDIT: maybe we can do the the ape way like this guy? sergiodxa/remix-utils#228 (comment). So what I am thinking is making a fork of main(prev2). Installing the package from my fork until this gets properly resolved.

@DonKoko DonKoko merged commit 8e6ef97 into main Oct 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: Upgrade remix to 2.x.x
1 participant